tree 41d324949f898ff453b96e189e9a844be335fcd5
parent 3475a9ec6c569dedb6cedba0ecf2072b7b842f27
author Chris Bracken <chris@bracken.jp> 1790641050 +0000
committer GitHub <noreply@github.com> 1790641050 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJquwdtCRC1aQ7uu5UhlAAAUwMQAA7oDX0rb/owa4rela6u6EoF
 VeXgxaxDz70JN7SQcBUj3vmO6F6HQlMjDr+RSTyYnmxN9fDqq7IhHxvLOPmKeHHQ
 hvf2M2hqr3fGZTxVrLXCOvvuW2TV1VqOmYMBm94vravT5e/JAffPP742/IXLid8E
 5ZuupvzVmfqFgcY1G+8GQHkLaSCOYvPVSbylOv50tpgjpuvHZCg3Jby8E2uQ3j7J
 K6LvSl11mazhrYx5tX+whk3RE99yi423i9Hh+2sGFw0MhqXMSg1jymmzYbFoH0AJ
 CMYrR11S0+YAg7Ipg8JzFJrO9XVS7Psed9uu4XqusBEc7jCPropCLF4fzn3UZiUf
 QJKkh2nicO+/K7dqWZe4RsQommv7nIqXJP1syLX+eMHQWlfkQJPFfgzOYeGB59DK
 yI0ZAKMZKQPuJqU6NXB8+2hnfLCpnGVRwA0TlT2w22t+nAJpf9+wISOrwbLX39XL
 yHoUWQ2GT+M8Fqb2obBrdGMcUKQAaW77UuC1oJ4qC7KBV6XLaD4eHNl9seGEz8b8
 fH36fw8//MlLof26fcKrY3yU8EFvCUv1HOnQmOGxy3fgb6Rbz7k3oNJ2anftflID
 9rz9+YJIrM9WPp/MprTvfn4jsOHVGxZRYNFDPOTPGolwXEmPxjPBxYvyqYRwsAD/
 jzRdiJF9G08lghqqT2yn
 =utnC
 -----END PGP SIGNATURE-----
 

shell: Rename first-frame tests AddFirstFrameCallback* (#193418)

In flutter/flutter#191841, we replaced `Shell::WaitForFirstFrame` with
`Shell::AddFirstFrameCallback` but didn't update the test names to match
the new API.

In particular, `WaitForFirstFrameTimeout` no longer tested that any
caller-visible timeout fired, since the new API manages the timeout
internally. The test now just verifies the first frame callback doesn't
fire when no frame has rendered.

Just naming changes, no semantic changes.

Issue: b/521830222


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant in-code documentation (doc comments with
`///`).
- [X] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md