commit fda193aa5d45b657295345fa2cc1107512d24f15
author Danny Tuppeny <danny@tuppeny.com> Tue Jan 15 15:39:35 2019 +0000
committer GitHub <noreply@github.com> Tue Jan 15 15:39:35 2019 +0000
tree e7c333d177864c1d04d9279a82cf270a0c684054
parent c713ef971e51e79733a5fb58345a401b6e690e17

Fix+unskip `flutter test` expression eval tests (#26579)

* Fix `flutter test`e xpression eval tests

We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.

* Ensure we wait for breakpoints before trying to evaluate

packages/flutter_tools/test/integration/expression_evaluation_test.dart

diff --git a/packages/flutter_tools/test/integration/expression_evaluation_test.dart b/packages/flutter_tools/test/integration/expression_evaluation_test.dart
index 5e18459..5118a27 100644
--- a/packages/flutter_tools/test/integration/expression_evaluation_test.dart
+++ b/packages/flutter_tools/test/integration/expression_evaluation_test.dart
@@ -102,6 +102,7 @@
         withDebugger: true,
         beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine),
       );
+      await _flutter.waitForPause();
       await evaluateTrivialExpressions(_flutter);
     });
 
@@ -110,6 +111,7 @@
         withDebugger: true,
         beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine),
       );
+      await _flutter.waitForPause();
       await evaluateComplexExpressions(_flutter);
     });
 
@@ -118,10 +120,11 @@
         withDebugger: true,
         beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine),
       );
+      await _flutter.waitForPause();
       await evaluateComplexReturningExpressions(_flutter);
     });
     // Skipped due to https://github.com/flutter/flutter/issues/26518
-  }, timeout: const Timeout.factor(6), skip: true);
+  }, timeout: const Timeout.factor(6));
 }
 
 Future<void> evaluateTrivialExpressions(FlutterTestDriver flutter) async {

packages/flutter_tools/test/integration/test_data/tests_project.dart

diff --git a/packages/flutter_tools/test/integration/test_data/tests_project.dart b/packages/flutter_tools/test/integration/test_data/tests_project.dart
index f5067af..c98d280 100644
--- a/packages/flutter_tools/test/integration/test_data/tests_project.dart
+++ b/packages/flutter_tools/test/integration/test_data/tests_project.dart
@@ -51,5 +51,5 @@
   Uri get breakpointUri => Uri.file(testFilePath);
 
   @override
-  int get breakpointLine => lineContaining(main, '// BREAKPOINT');
+  int get breakpointLine => lineContaining(testContent, '// BREAKPOINT');
 }

packages/flutter_tools/test/integration/test_driver.dart

diff --git a/packages/flutter_tools/test/integration/test_driver.dart b/packages/flutter_tools/test/integration/test_driver.dart
index bb10ec9..74b6cab 100644
--- a/packages/flutter_tools/test/integration/test_driver.dart
+++ b/packages/flutter_tools/test/integration/test_driver.dart
@@ -521,7 +521,7 @@
         '--machine',
         '-d',
         'flutter-tester'
-    ], script: testFile, withDebugger: withDebugger, pauseOnExceptions: pauseOnExceptions, pidFile: pidFile);
+    ], script: testFile, withDebugger: withDebugger, pauseOnExceptions: pauseOnExceptions, pidFile: pidFile, beforeStart: beforeStart);
   }
 
   @override