tree 26f2d040d26c26f5af94af0ff7b5845e584fce68
parent ff9dc22e44c81399cd790c3fddb5847c99ae41bc
author Chris Bracken <chris@bracken.jp> 1537290346 -0700
committer GitHub <noreply@github.com> 1537290346 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJboTBqCRBK7hj4Ov3rIwAAdHIIAAEnwcYu2GCou2VPr8Ycc3df
 CNORUdxX6kJeyS95cxnZi5ZhbUrQxY85mM/9RILZXl2w34FsNdlazKKJDhtoXR6p
 WGnOBD9ZdLyiUNbH5A5CtuCpbdWBGgyn9I5UGCPI59ooT4U6n3Qc02vBewAYPo/7
 H2sRqe5DSWG7vl8i2Qx/v3EvSDZpzhxAS+FVHW1kYnAmzTPGJFJ5ERbc8TFUWx3Y
 kxoWXJKhdlB9kOCzMC2IH5jJ08MEe4N7bN9skPiQAd5NFYQXAuCYMkS/GPRn+3fG
 yyS5se75AC7kVqXbRJnZp0Bn/W4osb2MIYbfBTfMnC3SvCJsSJDtSC3h3nSfM90=
 =eBOK
 -----END PGP SIGNATURE-----
 

Use Xcode legacy build system for iOS builds (#21901) (#21994)

Xcode 10 introduces a new build system which includes stricter checks on
duplicate build outputs.

When plugins are in use, there are two competing build actions that copy
Flutter.framework into the build application Frameworks directory:

  1. The Embed Frameworks build phase for the Runner project
  2. The [CP] Embed Pods Frameworks build phase that pod install creates
     in the project.

Item (1) is there to ensure the framework is copied into the built app
in the case where there are no plugins (and therefore no CocoaPods
integration in the Xcode project). Item (2) is there because Flutter's
podspec declares Flutter.framework as a vended_framework, and CocoaPods
automatically adds a copy step for each such vended_framework in the
transitive closure of CocoaPods dependencies.

As an immediate fix, we opt back into the build system used by Xcode 9
and earlier. Longer term, we need to update our templates and
flutter_tools to correctly handle this situation.

See: https://github.com/flutter/flutter/issues/20685