commit | 08080abd9cbb291cc3b4aec4f03454c9c8a88814 | [log] [tgz] |
---|---|---|
author | Mikhail <66741910+mishapark@users.noreply.github.com> | Fri Aug 11 20:12:27 2023 -0400 |
committer | GitHub <noreply@github.com> | Sat Aug 12 00:12:27 2023 +0000 |
tree | c35137117e34f0e03d91a922838b335ab86018e1 | |
parent | ea49db5093071a16fc8cd0e24044eac4541abf07 [diff] |
[google_maps_flutter] removed old overrides (#4679) Removed 2 overrides with the comment ``` // TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable. ``` As the issue was fixed in 2019 Related to https://github.com/flutter/flutter/issues/131791
diff --git a/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md b/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md index 4bec0d0..d9f5486 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md +++ b/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md
@@ -1,5 +1,5 @@ -## NEXT - +## 2.4.16 +* Removes old empty override methods. * Fixes unawaited_futures violations. ## 2.4.15
diff --git a/packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java b/packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java index 84d9fa7..c3a5ae6 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java +++ b/packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
@@ -604,20 +604,6 @@ googleMap.setOnMapLongClickListener(listener); } - // @Override - // The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum - // does. This will override it when available even with the annotation commented out. - public void onInputConnectionLocked() { - // TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable. - } - - // @Override - // The minimum supported version of Flutter doesn't have this method on the PlatformView interface, but the maximum - // does. This will override it when available even with the annotation commented out. - public void onInputConnectionUnlocked() { - // TODO(mklim): Remove this empty override once https://github.com/flutter/flutter/issues/40126 is fixed in stable. - } - // DefaultLifecycleObserver @Override
diff --git a/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml b/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml index 04c9f12..d04f3a3 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml +++ b/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml
@@ -2,7 +2,7 @@ description: Android implementation of the google_maps_flutter plugin. repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 -version: 2.4.15 +version: 2.4.16 environment: sdk: ">=2.18.0 <4.0.0"