commit | 2703b67eb4ee143f8a04a5d10cc3cf622588aa8c | [log] [tgz] |
---|---|---|
author | misos1 <30872003+misos1@users.noreply.github.com> | Wed Nov 20 23:20:10 2024 +0100 |
committer | GitHub <noreply@github.com> | Wed Nov 20 22:20:10 2024 +0000 |
tree | 47f38318106881f7ce0d06a1dcd6423987bcd271 | |
parent | 1cd499ec0c7164afb6ecf951565ff30c4ee42ce5 [diff] |
[video_player_avfoundation] send video load failure even when eventsink was initialized late (#7194) Event `initialized` is sent from `onListenWithArguments` by calling `setupEventSinkIfReadyToPlay` if event sink was `nil` during `observeValueForKeyPath`. This change also sends failure in a similar way. Adds more details to the error message returned by `VideoPlayerController.initialize()`. - https://github.com/flutter/flutter/issues/151475 - https://github.com/flutter/flutter/issues/147707 - https://github.com/flutter/flutter/issues/56665 - now error message may look like: `Failed to load video: Operation Stopped: The server is not correctly configured.: The operation couldnât be completed. (CoreMediaErrorDomain error -12939 - byte range and no content length - error code is 200)` Tests `testSeekToWhilePausedStartsDisplayLinkTemporarily` and `testSeekToWhilePlayingDoesNotStopDisplayLink` are failing on the main branch on ios. Seems position is correctly set to 1234 in `seekTo` completion handler but right after `[mockDisplayLink setRunning:YES]` is set again to 0 and after some time back to 1234 so those two tests sometimes fail (seems more often when running all tests).
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages
directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository: