commit 3c838819a2e2d4178041c55c04b143c24aba9618
author Sam Rawlins <sam.rawlins@gmail.com> Wed Nov 02 09:24:51 2022 -0700
committer GitHub <noreply@github.com> Wed Nov 02 09:24:51 2022 -0700
tree 037c07ab60406a18a94b28e4a3b4015567a5a1a4
parent 4b377226a42f713b3c2ed62375224f8ebfe21471

[flutter_markdown] Do not modify children of an Element after construction (#2758)

Do not modify children of a markdown Element after construction

The children list of an Element became unmodifiable in https://github.com/dart-lang/markdown/pull/463, so this just changes flutter_markdown to not modify the children, in a test.

Fixes https://github.com/dart-lang/markdown/issues/480

packages/flutter_markdown/test/custom_syntax_test.dart

diff --git a/packages/flutter_markdown/test/custom_syntax_test.dart b/packages/flutter_markdown/test/custom_syntax_test.dart
index 7fee7ce..6254a1b 100644
--- a/packages/flutter_markdown/test/custom_syntax_test.dart
+++ b/packages/flutter_markdown/test/custom_syntax_test.dart
@@ -160,9 +160,10 @@
 
   @override
   bool onMatch(md.InlineParser parser, Match match) {
-    final md.Element el = md.Element.withTag('wikilink');
-    el.attributes['href'] = match[1]!.replaceAll(' ', '_');
-    el.children!.add(md.Element.text('span', match[1]!));
+    final String link = match[1]!;
+    final md.Element el =
+        md.Element('wikilink', <md.Element>[md.Element.text('span', link)])
+          ..attributes['href'] = link.replaceAll(' ', '_');
 
     parser.addNode(el);
     return true;