| commit | 97e3ba64d783cba6ae7f0e8fd80bee8b9a0c12b5 | [log] [tgz] |
|---|---|---|
| author | stuartmorgan <stuartmorgan@google.com> | Wed May 24 08:39:26 2023 -0700 |
| committer | GitHub <noreply@github.com> | Wed May 24 15:39:26 2023 +0000 |
| tree | bbc06ce6da68eeee45621337b13c34e21de8d18f | |
| parent | f19282ab42fa3d0dcfdbe5bbb81d1a985bed1e21 [diff] |
[various] Fixes `unawaited_futures` violations (#4067) This option had been disabled to match flutter/flutter, but the reason it was disabled there was "too many false positives", mostly around animation. That doesn't apply to most packages here, and we've had a number of production bugsâespecially in plugins, that use async heavily in ways that are intended to be client-awaitableâthat this would have caught. This PR: - Enables the option at the repo level. - Permanently (unless the owners decide to change it) opts out `animations` and `go_router`, both of which looked like mostly or entirely false positives. - Temporarily opted out a few plugins that have a lot of violations that should be handled in their own PRs later (`camera_android_camerax`, most of `webview_flutter`). - Fixes all remaining violations. In many cases this PR is behavior-changing, replacing implicitly unawaited futures that did not seem obviously intentional with `await`ed futures, so non-test code in particular should be reviewed carefully to make sure the changes are correct. All of the changes are manual, not `fix`-generated. Part of https://github.com/flutter/flutter/issues/127323
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository:
