| commit | b7f1ad4b3395c410920e7e1d39d7cabc25a2eb72 | [log] [tgz] |
|---|---|---|
| author | Ahmed Fwela <63286031+ahmednfwela@users.noreply.github.com> | Thu Jun 15 00:33:10 2023 +0300 |
| committer | GitHub <noreply@github.com> | Wed Jun 14 21:33:10 2023 +0000 |
| tree | 0476d38f25da551211ac4871f3b3bf46314ca330 | |
| parent | c34ca5db3711bfd24504c3497e7bca1011ef4cf9 [diff] |
[flutter_adaptive_scaffold] Support RTL (#4204) This PR removes the hardcoded rtl directionality placed on top of `AdaptiveScaffold` for an unknown reason. | RTL | LTR | |-----|-----| |  |  | ## Changes in this PR - Core: Removed this hardcoded `Directionality` widget https://github.com/flutter/packages/blob/050729760b251e315af01876cc7d7de5dcfba0e9/packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart#L491-L494 - Core: Added tests to ensure text direction is passed correctly - Core: Modified `example/adaptive_scaffold_demo.dart` to demonstrate support for RTL - Side: There were some tests that were getting skipped, I have enabled them since their related issues landed on stable. - Side: Stopped ignoring `prefer_const_constructors` since it landed in stable as well. I made the commit messages as descriptive as possible so that it's easier to review relevant changes. ## Related issues - Supersedes #3602 - Fixes https://github.com/flutter/flutter/issues/119661 Question for reviewers: should the next version be 0.1.5 or 0.2.0 ?
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository:
