commit | c53e5c4f37f1d6697d71f837ad1ca4e08e65e332 | [log] [tgz] |
---|---|---|
author | auto-submit[bot] <98614782+auto-submit[bot]@users.noreply.github.com> | Wed Nov 20 21:25:26 2024 +0000 |
committer | GitHub <noreply@github.com> | Wed Nov 20 21:25:26 2024 +0000 |
tree | 7ef697ff04378c697166896cec12f4251cad6c83 | |
parent | 59a1067db64aad91ba1b56c77d6dbc1aa5cf2481 [diff] |
Reverts "[url_launcher] Add Swift Package Manager integration to example app (#8128)" (#8136) Reverts: flutter/packages#8128 Initiated by: loic-sharma Reason for reverting: this caused the license checker to [error](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8730732827684094689/+/u/Run_package_tests/license_validation/stdout): ``` The license block for these files is missing or incorrect: /b/s/w/ir/x/w/packages/packages/url_launcher/url_launcher/example/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift /b Original PR Author: loic-sharma Reviewed By: {stuartmorgan} This change reverts the following previous change: This migrates the example app to have Swift Package Manager integration. This raises the example app's Flutter SDK requirement to 3.24.0 or higher. Scenarios: 1. **Run the example app using Flutter 3.24 or higher with SwiftPM feature on**: Plugin is added using Swift Package Manager. 2. **Run the example app using Flutter 3.24 or higher with SwiftPM feature off**: Plugin is added using CocoaPods. The tool generates an empty `FlutterGeneratedPluginSwiftPackage` local package. 3. **Run the example app using Flutter version lower than 3.24**: you get a build error because the example app's Xcode project expects a `FlutterGeneratedPluginSwiftPackage` local package but cannot find it. Part of: https://github.com/flutter/flutter/issues/159173 ### Tests Current tests build the example apps twice: once with SwiftPM on, once with SwiftPM off. Currently, the tests with SwiftPM on also migrate the example app to add SwiftPM integration. After this change, these tests will no longer need to migrate the example app as it is already migrated. In other words, this change is covered by existing tests. ### Migration steps The app was migrated using these steps: ```console flutter channel master flutter upgrade flutter config --enable-swift-package-manager flutter build ios --config-only flutter build macos --config-only ```
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages
directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository: