| commit | aad08ecb973ea67bd9cd40a88654f3ee9df30781 | [log] [tgz] |
|---|---|---|
| author | Camille Simon <43054281+camsim99@users.noreply.github.com> | Thu Jan 09 13:30:52 2025 -0600 |
| committer | GitHub <noreply@github.com> | Thu Jan 09 19:30:52 2025 +0000 |
| tree | 7b117c5e24d9f01a07e7064f808642351e3d1da4 | |
| parent | 0f429432165eae8b334a8cf0eb49a2c66d47dc27 [diff] |
[camera_android_camerax] Remove logic used to previously correct preview rotation (#8256) Removes correction logic used to the correct the rotation of the camera preview, since it appears* to not be needed anymore. Partially addresses https://github.com/flutter/flutter/issues/154241. *This is **not true** for emulators, but if we are ok landing this issue for real devices, I'll file an issue for emulators and follow up there. jonahwilliams@ mentioned there is known different behavior in emulators with Impeller, so this fact is not totally a surprise. My basis for landing this is: 1. I tested the following devices that use both Impeller backends and this PR works: - Realme X2 Pro, Android 11 (API 30) that uses Vulkan - Pixel 3A, Android 12 (Android 31/32) that falls back to OpenGLES - Samsung Galaxy (Android 8.1.0) that uses OpenGLES 2. If this misses an edge case (like a class of device), this PR will make it easier to debug what is going on, since the camera preview will now **only** introduce a rotation if the device itself is rotated (as per the logic in https://github.com/flutter/packages/blob/8ca81bd20231ed638cfc3ebf5f8a3f96b3d22e60/packages/camera/camera/lib/src/camera_preview.dart#L46-L72) with no additional logic concerning the sensor orientation and UI orientation as it does now.
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository:
