| commit | 95b995946368e96ee3adfb1d176d60446202322b | [log] [tgz] |
|---|---|---|
| author | stuartmorgan <stuartmorgan@google.com> | Fri Sep 29 10:03:59 2023 -0700 |
| committer | GitHub <noreply@github.com> | Fri Sep 29 17:03:59 2023 +0000 |
| tree | a7f5d82a232201984ee6acc9134246a0c903bf49 | |
| parent | 5862201174fc1ea02f9b029db7fb916a87db45ae [diff] |
[camera] Remove `@throw` from iOS implementation (#5034) Using `@throw` in iOS code violates the style guide, so it shouldn't be done in the plugin as mechanism for communicating errors. More importantly, `NSError` is not intended to be used with `@throw`/`@catch`, and is causing issues when compiled with the iOS 17 SDK. This removes all use of `@throw`, and all `@catch (NSError* e)`, in favor of other methods of communicating errors. It explicitly does not try to fix all the other strange things about this code (having an `NSError` out-param in an init method, using Cocoa and NSURL error domains and codes for some reason), and instead preserves existing behavior as much as possible. In practice, none of these codepaths should ever actually happen (they indicate programming errors within the plugin, not unexpected runtime behavior), and all of this code will go away when converting to Pigeon anyway, so there's not much value in trying to unwind this structure further. Fixes https://github.com/flutter/flutter/issues/135195
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository:
