commit | fd84e6545a450b758b233228728e7c71530984db | [log] [tgz] |
---|---|---|
author | Yam Horesh <48316647+yamhoresh@users.noreply.github.com> | Thu Oct 12 21:42:00 2023 +0300 |
committer | GitHub <noreply@github.com> | Thu Oct 12 18:42:00 2023 +0000 |
tree | aed91bca66612cd9bf2bde6611bf4bd14c75cb6e | |
parent | 6d4354c90cf2926835a52c16c2ab1f1a38e2cac3 [diff] |
[go_router] Fix missing build parameter in type-safe routes topic documentation (#5040) Added the missing GoRouterState state parameter to the build methods of `HomeScreenRoute` and `SongRoute`, to the type-safe routes [topic](https://github.com/flutter/packages/blob/main/packages/go_router/doc/type-safe-routes.md). Using the current documentation (without the fix), raises the error: ``` dart 'HomeScreenRoute.build' ('Widget Function(BuildContext)') isn't a valid override of 'GoRouteData.build' ('Widget Function(BuildContext, GoRouterState)') ``` I didn't find any issue for this, but if you'd want I could simply open one myself and link it to this pull request.
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages
directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository: