commit | 9f0e92f2273a459fbb0192653e8db4a76dee2faf | [log] [tgz] |
---|---|---|
author | David Iglesias <ditman@gmail.com> | Wed Nov 01 13:55:19 2023 -0700 |
committer | GitHub <noreply@github.com> | Wed Nov 01 20:55:19 2023 +0000 |
tree | 9d534319e1293582caf75778ef2c3a48a8ba8004 | |
parent | e780cb8e79a57bfacccac41dd565b0ece89b68fa [diff] |
[video_player_web] Listen to loadedmetadata event from video element. (#5289) This PR configures the underlying HTMLVideoElement used by the plugin so it triggers a `VideoEventType.initialized` both for `canplay` (current behavior) and `loadedmetadata` events (fixes iOS 17). It also sets `src` as the last configuration value when creating the VideoElement, which is common practice when listening to events from HTMLElements, like `img` or even `iframe`s. ### Issues * Fixes: **P1** https://github.com/flutter/flutter/issues/137023 ### Tests * Added a small integration test to ensure `loadedmetadata` triggers the expected VideoPlayer event. * Deployed changes to: https://dit-videoplayer-tests.web.app for manual verification on an actual iOS device.
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages
directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository: