tree 69aefab8e9062cd281dd077c23712569d60ffe0a
parent 644d85be6adedbe8f56cbb3c5efb6cdabe78e50f
author stuartmorgan <stuartmorgan@google.com> 1662265315 -0400
committer GitHub <noreply@github.com> 1662265315 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJjFCfjCRBK7hj4Ov3rIwAATScIAKZRXiRhBj9E7SvXCMytCdu/
 4GtEqfrnu7uDZWeRnRtAg3DswCXHX8YB9YzHUwTJXeE+iaH4xJG0iQgyHIxsEB7O
 iOyzotMenHSjUiWznGepGMM9gl+P5GBdPkemnbYfcBnPurNs51PS559ufPjEgcIo
 hrD7J2ynI9q2fTRi+yobQvC/SpXF1kj0b2khBnkhWdBEhAZG0pCsJQ6pZsnM32wE
 0pl9olHq8erpP0BaE2UCT+4e62ru4Fe80U6Gdw3MegBFGXCNwlzQ8kad73INaA1v
 ga1FUAWmvOIle/dtDkY/LoiYEyQ100gPWqYmU/tUcCOsx4qdQIP8n4YTPn0F8XE=
 =bueA
 -----END PGP SIGNATURE-----
 

[video_player] Remove default method channel implementation (#6341)

Eliminates `MethodChannelVideoPlayer`, and instead makes the default a
no-op subclass of the interface (i.e., one that throws
`UnimplementedError` for everything). This moves the plugin from option
3 to option 2 in
https://docs.flutter.dev/go/platform-channels-in-federated-plugins.

This implementation is being removed because its use of Pigeon made
ongoing maintenance impractical. Since default implementations are
intended for backward compatibility with third-party native-only
implementations, the platform channel internals of default
implementations are considered part of the API surface. Pigeon considers
those details implementation details, which means it was impossible to
ever update the version of Pigeon used here without breaking changes.
This means that fundamentally, Pigeon is not a viable choice for default
implementations.

The alternative to removing it would be replacing it with a new
non-Pigeon method channel implementation, but that would also be a
breaking change, defeating the purpose of backward compatibility.
This would only benefit new third-party implementations, but new
implementations should implement the platform interface rather than
using the legacy default implementation.

Fixes https://github.com/flutter/flutter/issues/110017