Fix trivial deprecations
R=fujino@google.com
Change-Id: Iacd250fc0a9e0fec4ea07ec1e1d43563969158f5
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/59321
Reviewed-by: Christopher Fujino <fujino@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
diff --git a/recipe_modules/display_util/api.py b/recipe_modules/display_util/api.py
index 1d82d71..39e168d 100644
--- a/recipe_modules/display_util/api.py
+++ b/recipe_modules/display_util/api.py
@@ -40,19 +40,19 @@
with self.m.step.nest(step_name) as presentation:
for id_name, build in subbuilds.items():
with self.m.step.nest(build.build_name) as display_step:
- step_links = display_step.presentation.links
+ step_links = display_step.links
step_links[str(build.build_id)] = build.url
if build.build_proto.status == common_pb2.Status.Value('SUCCESS'):
- display_step.presentation.status = self.m.step.SUCCESS
+ display_step.status = self.m.step.SUCCESS
elif build.build_proto.status in infra_failure_states:
- display_step.presentation.status = self.m.step.EXCEPTION
+ display_step.status = self.m.step.EXCEPTION
infra_failures.append(build)
elif build.build_proto.status == common_pb2.Status.Value('FAILURE'):
- display_step.presentation.status = self.m.step.FAILURE
+ display_step.status = self.m.step.FAILURE
failures.append(build)
# For any other status, use warning color.
else:
- display_step.presentation.status = self.m.step.WARNING
+ display_step.status = self.m.step.WARNING
def summary_section(build):
url = self.m.buildbucket.build_url(build_id=build.build_id)
@@ -117,20 +117,20 @@
for k in builds:
build = builds[k] if isinstance(k, long) or isinstance(k, int) else k
with self.m.step.nest(build.builder.builder) as display_step:
- step_links = display_step.presentation.links
+ step_links = display_step.links
step_links[str(build.id)
] = self.m.buildbucket.build_url(build_id=build.id)
if build.status == common_pb2.Status.Value('SUCCESS'):
- display_step.presentation.status = self.m.step.SUCCESS
+ display_step.status = self.m.step.SUCCESS
elif build.status in infra_failure_states:
- display_step.presentation.status = self.m.step.EXCEPTION
+ display_step.status = self.m.step.EXCEPTION
infra_failures.append(build)
elif build.status == common_pb2.Status.Value('FAILURE'):
- display_step.presentation.status = self.m.step.FAILURE
+ display_step.status = self.m.step.FAILURE
failures.append(build)
# For any other status, use warning color.
else:
- display_step.presentation.status = self.m.step.WARNING
+ display_step.status = self.m.step.WARNING
def summary_section(build):
url = self.m.buildbucket.build_url(build_id=build.id)
@@ -205,7 +205,7 @@
links (Dict): A dictionary with the task links as values and the task id as keys.
"""
with self.m.step.nest(result.name) as display_step:
- step_links = display_step.presentation.links
+ step_links = display_step.links
step_links[str(result.id)] = links[result.id]
if (result.state is None or
result.state != self.m.swarming.TaskState.COMPLETED):
@@ -215,7 +215,7 @@
display_step.status = self.m.step.FAILURE
failed_builders.append(result.name)
else:
- display_step.presentation.status = self.m.step.WARNING
+ display_step.status = self.m.step.WARNING
def _display(
self,
diff --git a/recipe_modules/os_utils/api.py b/recipe_modules/os_utils/api.py
index 9da278f..e8d2dd9 100644
--- a/recipe_modules/os_utils/api.py
+++ b/recipe_modules/os_utils/api.py
@@ -375,7 +375,7 @@
except self.m.step.InfraFailure:
# If step fails, continue to "Run app to dismiss dialogs" step.
# That step should also fail.
- wait_connect_step.presentation.status = self.m.step.INFRA_FAILURE
+ wait_connect_step.status = self.m.step.INFRA_FAILURE
finally:
self._list_core_devices()
self.m.step(
diff --git a/recipe_modules/osx_sdk/api.py b/recipe_modules/osx_sdk/api.py
index 1df8e38..15bf0e4 100644
--- a/recipe_modules/osx_sdk/api.py
+++ b/recipe_modules/osx_sdk/api.py
@@ -766,7 +766,7 @@
self.m.step.empty(
'runtime build version', step_text=ios_runtime_build_version
)
- display_step.presentation.status = self.m.step.SUCCESS
+ display_step.status = self.m.step.SUCCESS
# Check if runtime is already mounted
for runtime in runtime_simulators:
diff --git a/recipe_modules/subbuild/api.py b/recipe_modules/subbuild/api.py
index af3b14e..87af929 100644
--- a/recipe_modules/subbuild/api.py
+++ b/recipe_modules/subbuild/api.py
@@ -153,7 +153,7 @@
for k, v in sorted(properties.items()):
edit_args.extend(["-p", f"{k}={self.m.json.dumps(v)}"])
edit_cr_cl_arg = None
- bb_input = self.m.buildbucket.build_input
+ bb_input = self.m.buildbucket.build.input
if bb_input.gerrit_changes:
gerrit_change = bb_input.gerrit_changes[0]
edit_cr_cl_arg = f"https://{gerrit_change.host}/c/{gerrit_change.project}/+/{int(gerrit_change.change)}"
