commit | 17605c753f6d63def4cfea85f688b282e3d6dbce | [log] [tgz] |
---|---|---|
author | Hzj_jie <zijiehe@google.com> | Tue Mar 05 21:33:08 2024 +0000 |
committer | CQ Bot Account <flutter-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 05 21:33:08 2024 +0000 |
tree | 3f985dd0a6e0b1ebaf5b0452a3e6e2b5d5322d42 | |
parent | 91de3640f279744b1edcb8678e480c53ec7521ec [diff] |
[engine_v2] respect gclient_variables from parent build For fuchsia lsc tests, the parent builder is triggered by a fuchsia change with customized `gclient_variables` to specify the non-released fuchsia sdk. These gclient_variables are used by DEPS and src/flutter/tools/download_fuchsia_sdk.py to download the fuchsia sdk from gcs rather than the released ones in cipd. (https://github.com/flutter/engine/blob/3e8b0deffe4e01fa7364024a0f0f2fda01909a9f/DEPS#L1128) But the `gclient_variables` were never really forwarded to the drone builders, and caused the fuchsia lsc tests to not function as its purpose, e.g. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2075085/overview More details can be found in http://b/328110079. So this change propagates the `gclient_variables` from parent builder to the drone builders if any. Meanwhile the `gclient_variables` specifically defined in the ci/builders/*.json are still being respected and have higher priority to override anything conflicting. Bug: b/328110079 Change-Id: I34f022b358206e3a7603db18895bf63a33b751f9 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/55760 Commit-Queue: Zijie He <zijiehe@google.com> Reviewed-by: Keyong Han <keyonghan@google.com>
This repository contains Flutter's LUCI recipes. For the LUCI infrastructure config, see flutter/infra. Builds can be found in the Flutter Dashboard.
Supported repositories roll their .ci.yaml
into flutter/infra, which updates what properties builds have. For example, flutter config specifies various dependencies the different tests require, which are then used by the flutter_deps recipe_module No modifications to flutter/infra are required to work on the recipes.
Please follow instructions on Contributing docs to set up your development environment.