commit 1afc5be2a2c523679300f3a0e53547369ac95a62
author Zach Anderson <zra@google.com> Fri Jun 24 21:57:56 2022 +0000
committer CQ Bot Account <flutter-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 24 21:57:56 2022 +0000
tree 0e6dda89f0b8ef8341c1de528eaea16733a24498
parent 66abe89caa33a1db5e7278c41c3abd1caaadfe8f

Remove license check from Linux Unopt

led run: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/zra_google.com/808eb299afda0c0b0cc90ac6d5b95600ce29ed48b522efcade9d5c85061f661e/+/build.proto?server=chromium-swarm.appspot.com

Change-Id: I260c5865a9ea4173b805f38288fd368c590ab5c1
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/31562
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Dan Field <dnfield@google.com>

recipes/engine/engine_unopt.expected/linux.json

diff --git a/recipes/engine/engine_unopt.expected/linux.json b/recipes/engine/engine_unopt.expected/linux.json
index 8369a9f..f891973 100644
--- a/recipes/engine/engine_unopt.expected/linux.json
+++ b/recipes/engine/engine_unopt.expected/linux.json
@@ -530,45 +530,6 @@
     "name": "test: format and dart test"
   },
   {
-    "cmd": [
-      "[CACHE]/builder/src/flutter/ci/licenses.sh"
-    ],
-    "cwd": "[CACHE]/builder/src",
-    "env": {
-      "ANDROID_HOME": "[CACHE]/builder/src/third_party/android_tools/sdk",
-      "FLUTTER_LOGS_DIR": "[CLEANUP]/flutter_logs_dir",
-      "FLUTTER_PREBUILT_DART_SDK": "True",
-      "FLUTTER_TEST_OUTPUTS_DIR": "[CLEANUP]/flutter_logs_dir",
-      "GOMA_DIR": "[CACHE]/goma/client"
-    },
-    "env_prefixes": {
-      "PATH": [
-        "[CACHE]/builder/src/third_party/dart/tools/sdks/dart-sdk/bin"
-      ]
-    },
-    "env_suffixes": {
-      "DEPOT_TOOLS_UPDATE": [
-        "0"
-      ],
-      "PATH": [
-        "RECIPE_REPO[depot_tools]"
-      ]
-    },
-    "luci_context": {
-      "realm": {
-        "name": "flutter:ci"
-      },
-      "resultdb": {
-        "current_invocation": {
-          "name": "invocations/build:8945511751514863184",
-          "update_token": "token"
-        },
-        "hostname": "rdbhost"
-      }
-    },
-    "name": "licenses check"
-  },
-  {
     "cmd": [],
     "name": "ensure goma (2)"
   },

recipes/engine/engine_unopt.expected/linux_lto.json

diff --git a/recipes/engine/engine_unopt.expected/linux_lto.json b/recipes/engine/engine_unopt.expected/linux_lto.json
index 11fd285..6b75f64 100644
--- a/recipes/engine/engine_unopt.expected/linux_lto.json
+++ b/recipes/engine/engine_unopt.expected/linux_lto.json
@@ -530,45 +530,6 @@
     "name": "test: format and dart test"
   },
   {
-    "cmd": [
-      "[CACHE]/builder/src/flutter/ci/licenses.sh"
-    ],
-    "cwd": "[CACHE]/builder/src",
-    "env": {
-      "ANDROID_HOME": "[CACHE]/builder/src/third_party/android_tools/sdk",
-      "FLUTTER_LOGS_DIR": "[CLEANUP]/flutter_logs_dir",
-      "FLUTTER_PREBUILT_DART_SDK": "True",
-      "FLUTTER_TEST_OUTPUTS_DIR": "[CLEANUP]/flutter_logs_dir",
-      "GOMA_DIR": "[CACHE]/goma/client"
-    },
-    "env_prefixes": {
-      "PATH": [
-        "[CACHE]/builder/src/third_party/dart/tools/sdks/dart-sdk/bin"
-      ]
-    },
-    "env_suffixes": {
-      "DEPOT_TOOLS_UPDATE": [
-        "0"
-      ],
-      "PATH": [
-        "RECIPE_REPO[depot_tools]"
-      ]
-    },
-    "luci_context": {
-      "realm": {
-        "name": "flutter:ci"
-      },
-      "resultdb": {
-        "current_invocation": {
-          "name": "invocations/build:8945511751514863184",
-          "update_token": "token"
-        },
-        "hostname": "rdbhost"
-      }
-    },
-    "name": "licenses check"
-  },
-  {
     "cmd": [],
     "name": "ensure goma (2)"
   },

recipes/engine/engine_unopt.py

diff --git a/recipes/engine/engine_unopt.py b/recipes/engine/engine_unopt.py
index 3030fd5..14f3e1a 100644
--- a/recipes/engine/engine_unopt.py
+++ b/recipes/engine/engine_unopt.py
@@ -108,13 +108,6 @@
       api.step('dart bin/main.dart', ['dart', 'bin/main.dart'])
 
 
-def CheckLicenses(api):
-  checkout = GetCheckoutPath(api)
-  with api.context(cwd=checkout):
-    licenses_cmd = checkout.join('flutter', 'ci', 'licenses.sh')
-    api.step('licenses check', [licenses_cmd])
-
-
 def BuildLinuxAndroid(api, swarming_task_id):
   # Build Android Unopt and run tests
   RunGN(api, '--android', '--unoptimized')
@@ -246,7 +239,6 @@
       # Checks before building the engine. Only run on Linux.
       if api.platform.is_linux:
         FormatAndDartTest(api)
-        CheckLicenses(api)
         BuildLinux(api)
         AnalyzeDartUI(api)
         TestObservatory(api)