Remove android-x86 Firebase tests.
Change-Id: I0745ecbc5f7ffb4cd9a839b5a8bf233b5f8f1fbe
Bug: https://github.com/flutter/flutter/pull/169884
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/66160
Reviewed-by: Jason Simmons <jsimmons@google.com>
Commit-Queue: Matan Lurey <matanl@google.com>
diff --git a/recipes/firebaselab/firebaselab.py b/recipes/firebaselab/firebaselab.py
index cfbd7ea..a5ca3ff 100644
--- a/recipes/firebaselab/firebaselab.py
+++ b/recipes/firebaselab/firebaselab.py
@@ -59,26 +59,18 @@
'virtual_devices'
) is None else api.properties.get('virtual_devices')
- test_configurations = (
- (
- 'Build appbundle', [
- 'flutter', 'build', 'appbundle', '--target-platform',
- 'android-arm,android-arm64'
- ], 'build/app/outputs/bundle/release/app-release.aab',
- list(physical_devices)
- ),
- # Use apk because if you let the virtual device pick, it may pick an ARM binary and use
- # runtime translation. We have seen runtime crashes in ARM translation that don't seem to
- # occur on physical devices with the same binary. In summary we are trying to make sure
- # the virtual device is getting a specific architecture that is less likely to crash/have issues.
- (
- 'Build apk', [
- 'flutter', 'build', 'apk', '--debug', '--target-platform',
- 'android-x86'
- ], 'build/app/outputs/flutter-apk/app-debug.apk',
- list(virtual_devices)
- ),
- )
+ test_configurations = ((
+ 'Build appbundle',
+ [
+ 'flutter',
+ 'build',
+ 'appbundle',
+ '--target-platform',
+ 'android-arm,android-arm64',
+ ],
+ 'build/app/outputs/bundle/release/app-release.aab',
+ list(physical_devices),
+ ),)
with api.context(env=env, env_prefixes=env_prefixes, cwd=checkout_path):
# Run flutter doctor and update packages.
@@ -104,17 +96,22 @@
infra_step=True,
)
for step_name, build_command, binary, devices in test_configurations:
- # Skip running gcloud command if no devices were provided.
- if not devices:
- continue
# Build the app bundle or apk.
api.step(step_name, build_command)
# Run run the binary in firebaselab using the provided device configurations.
firebase_cmd = [
- 'firebase', 'test', 'android', 'run', '--type', 'robo', '--app',
- binary, '--timeout', '2m',
+ 'firebase',
+ 'test',
+ 'android',
+ 'run',
+ '--type',
+ 'robo',
+ '--app',
+ binary,
+ '--timeout',
+ '2m',
'--results-bucket=gs://%s' % gcs_bucket,
- '--results-dir=%s/%s' % (task_name, task_id)
+ '--results-dir=%s/%s' % (task_name, task_id),
] + devices
# See https://firebase.google.com/docs/test-lab/android/command-line#script_exit_codes
@@ -154,6 +151,7 @@
# Collect memory/cpu/process after task execution.
api.os_utils.collect_os_info()
+
def GenTests(api):
physical_devices = ['--device', 'model=redfin,version=30']
yield api.test(
