Pass dashing version correctly.
The dashing version being passed from ci.yaml was being ignored. This
CL ensures the version is passed all the way to the go module
installation.
Change-Id: Icb73f058df6f92cfcf3c2f61ca7da1824943fdd3
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/37086
Commit-Queue: Godofredo Contreras <godofredoc@google.com>
Reviewed-by: Drew Roen <drewroen@google.com>
diff --git a/recipe_modules/flutter_deps/api.py b/recipe_modules/flutter_deps/api.py
index b1367e9..7ed10df 100644
--- a/recipe_modules/flutter_deps/api.py
+++ b/recipe_modules/flutter_deps/api.py
@@ -229,12 +229,12 @@
def dashing(self, env, env_prefixes, version):
"""Installs dashing."""
- version = version or 'git_revision:ed8da90e524f59c69781c8af65638f108d0bbba6'
+ version = version or '0.4.0'
self.go_sdk(env, env_prefixes, 'version:2@1.19.3')
with self.m.context(env=env, env_prefixes=env_prefixes):
self.m.step(
'Install dashing',
- ['go', 'install', 'github.com/technosophos/dashing@latest'],
+ ['go', 'install', 'github.com/technosophos/dashing@%s' % version],
infra_step=True,
)
diff --git a/recipe_modules/flutter_deps/examples/full.expected/basic.json b/recipe_modules/flutter_deps/examples/full.expected/basic.json
index f71374f..54c4ba7 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/basic.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/basic.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json b/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json
index dbd0659..5b33f44 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json b/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json
index f71374f..54c4ba7 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/linux.json b/recipe_modules/flutter_deps/examples/full.expected/linux.json
index f71374f..54c4ba7 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/linux.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/linux.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/local_engine_cas.json b/recipe_modules/flutter_deps/examples/full.expected/local_engine_cas.json
index 3ca893f..c3d4e15 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/local_engine_cas.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/local_engine_cas.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/mac.json b/recipe_modules/flutter_deps/examples/full.expected/mac.json
index ad09499..3a19982 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/mac.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/mac.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome-mac/Chromium.app/Contents/MacOS/Chromium",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/windows.json b/recipe_modules/flutter_deps/examples/full.expected/windows.json
index b0dad1d..4f7e5a0 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/windows.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/windows.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]\\chrome\\chrome\\chrome.exe",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/with-arm64ruby.json b/recipe_modules/flutter_deps/examples/full.expected/with-arm64ruby.json
index ea3ea89..25c37cd 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/with-arm64ruby.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/with-arm64ruby.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome",
diff --git a/recipe_modules/flutter_deps/examples/full.expected/with-gems.json b/recipe_modules/flutter_deps/examples/full.expected/with-gems.json
index 57ef6b5..e409a1d 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/with-gems.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/with-gems.json
@@ -250,7 +250,7 @@
"cmd": [
"go",
"install",
- "github.com/technosophos/dashing@latest"
+ "github.com/technosophos/dashing@v5"
],
"env": {
"CHROME_EXECUTABLE": "[CACHE]/chrome/chrome/chrome",
