commit 3d9ae38320f6b95a9b04f047cddbb9e67fd086d3
author Godofredo Contreras <godofredoc@google.com> Tue May 30 23:13:52 2023 +0000
committer CQ Bot Account <flutter-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 30 23:13:52 2023 +0000
tree d6897a726e17ce8d9da0f882cf488657493b0484
parent da9283cf9b5130e3aa5e1a52a032535336735842

Move firebaselab configs to ci.yaml.

The current implementation forces to update recipes to
add/remove/updated physical or virtual devices from firebaselab tests.
This forces a monolithic tests running all the configurations and
removes the ability to move some configs to bringup.

This change moves the configurations to properties that can be passed
from .ci.yaml. It will allow to split the monolithic test as multiple
builds that can be marked as bringup independently.

Bug: https://github.com/flutter/flutter/issues/127884
Bug: https://github.com/flutter/flutter/issues/118736
Change-Id: I063ce80c7936bfa00fa14473cd253ac4ae46fd89
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/45182
Commit-Queue: Godofredo Contreras <godofredoc@google.com>
Reviewed-by: Reid Baker <reidbaker@google.com>

recipes/firebaselab/firebaselab.py

diff --git a/recipes/firebaselab/firebaselab.py b/recipes/firebaselab/firebaselab.py
index a72d0cf..42b25b1 100644
--- a/recipes/firebaselab/firebaselab.py
+++ b/recipes/firebaselab/firebaselab.py
@@ -38,7 +38,7 @@
   api.flutter_deps.required_deps(env, env_prefixes, deps)
   task_name = api.properties.get('task_name')
 
-  physical_devices = [
+  default_physical_devices = [
       # Physical devices - use only highly available devices to avoid timeouts.
       # Pixel 3
       # Disable temporarily to unblock the rolls https://github.com/flutter/flutter/issues/118708
@@ -52,7 +52,7 @@
       'model=griffin,version=24',
   ]
 
-  virtual_devices = [
+  default_virtual_devices = [
       # SDK 20 not available virtually or physically.
       '--device',
       'model=Nexus5,version=21',
@@ -74,19 +74,27 @@
       # SDK 30 is run on a physical redfin/Pixel 5 above.
   ]
 
+  physical_devices = api.properties.get(
+      'physical_devices'
+  ) or default_physical_devices
+  virtual_devices = api.properties.get(
+      'virtual_devices'
+  ) or default_virtual_devices
+
   test_configurations = (
       (
           'Build appbundle', [
               'flutter', 'build', 'appbundle', '--target-platform',
               'android-arm,android-arm64'
           ], 'build/app/outputs/bundle/release/app-release.aab',
-          physical_devices
+          list(physical_devices)
       ),
       (
           'Build apk', [
               'flutter', 'build', 'apk', '--debug', '--target-platform',
               'android-x86'
-          ], 'build/app/outputs/flutter-apk/app-debug.apk', virtual_devices
+          ], 'build/app/outputs/flutter-apk/app-debug.apk',
+          list(virtual_devices)
       ),
   )