Add local-engine-host option to framework-smoke recipe
A mandatory local-engine-host option has been added to flutter
tools for invocations that use the local-engine option.
Add this option to the calls in the framework-smoke recipe.
Bug: https://github.com/flutter/flutter/issues/132245
Change-Id: Ib140d98a3ca85a4529eb5125887bcf3143d44b86
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/49620
Reviewed-by: Casey Hillers <chillers@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
diff --git a/recipes/engine/framework_smoke.expected/basic.json b/recipes/engine/framework_smoke.expected/basic.json
index 119b2c8..3079ecd 100644
--- a/recipes/engine/framework_smoke.expected/basic.json
+++ b/recipes/engine/framework_smoke.expected/basic.json
@@ -873,7 +873,8 @@
"bin/flutter",
"update-packages",
"-v",
- "--local-engine=[CACHE]/builder/src/out/host_debug_unopt"
+ "--local-engine=[CACHE]/builder/src/out/host_debug_unopt",
+ "--local-engine-host=host_debug_unopt"
],
"cwd": "[CACHE]/flutter",
"env": {
@@ -889,7 +890,8 @@
"bin/flutter",
"analyze",
"--flutter-repo",
- "--local-engine=[CACHE]/builder/src/out/host_debug_unopt"
+ "--local-engine=[CACHE]/builder/src/out/host_debug_unopt",
+ "--local-engine-host=host_debug_unopt"
],
"cwd": "[CACHE]/flutter",
"env": {
@@ -908,7 +910,8 @@
"cmd": [
"[CACHE]/flutter/bin/flutter",
"test",
- "--local-engine=[CACHE]/builder/src/out/host_debug_unopt"
+ "--local-engine=[CACHE]/builder/src/out/host_debug_unopt",
+ "--local-engine-host=host_debug_unopt"
],
"cwd": "[CACHE]/flutter/packages/flutter",
"env": {
diff --git a/recipes/engine/framework_smoke.expected/no_goma.json b/recipes/engine/framework_smoke.expected/no_goma.json
index 119b2c8..3079ecd 100644
--- a/recipes/engine/framework_smoke.expected/no_goma.json
+++ b/recipes/engine/framework_smoke.expected/no_goma.json
@@ -873,7 +873,8 @@
"bin/flutter",
"update-packages",
"-v",
- "--local-engine=[CACHE]/builder/src/out/host_debug_unopt"
+ "--local-engine=[CACHE]/builder/src/out/host_debug_unopt",
+ "--local-engine-host=host_debug_unopt"
],
"cwd": "[CACHE]/flutter",
"env": {
@@ -889,7 +890,8 @@
"bin/flutter",
"analyze",
"--flutter-repo",
- "--local-engine=[CACHE]/builder/src/out/host_debug_unopt"
+ "--local-engine=[CACHE]/builder/src/out/host_debug_unopt",
+ "--local-engine-host=host_debug_unopt"
],
"cwd": "[CACHE]/flutter",
"env": {
@@ -908,7 +910,8 @@
"cmd": [
"[CACHE]/flutter/bin/flutter",
"test",
- "--local-engine=[CACHE]/builder/src/out/host_debug_unopt"
+ "--local-engine=[CACHE]/builder/src/out/host_debug_unopt",
+ "--local-engine-host=host_debug_unopt"
],
"cwd": "[CACHE]/flutter/packages/flutter",
"env": {
diff --git a/recipes/engine/framework_smoke.py b/recipes/engine/framework_smoke.py
index 478c9a0..5806156 100644
--- a/recipes/engine/framework_smoke.py
+++ b/recipes/engine/framework_smoke.py
@@ -66,14 +66,20 @@
)
api.step(
'Update packages', [
- 'bin/flutter', 'update-packages', '-v',
- '--local-engine=%s' % str(build_dir)
+ 'bin/flutter',
+ 'update-packages',
+ '-v',
+ '--local-engine=%s' % str(build_dir),
+ '--local-engine-host=host_debug_unopt',
]
)
api.step(
'Framework analyze', [
- 'bin/flutter', 'analyze', '--flutter-repo',
- '--local-engine=%s' % str(build_dir)
+ 'bin/flutter',
+ 'analyze',
+ '--flutter-repo',
+ '--local-engine=%s' % str(build_dir),
+ '--local-engine-host=host_debug_unopt',
]
)
# Run framework packages test
@@ -82,8 +88,10 @@
cwd=flutter_checkout_path.join('packages', 'flutter')):
api.step(
api.test_utils.test_step_name('Framework test'), [
- str(flutter_checkout_path.join('bin', 'flutter')), 'test',
- '--local-engine=%s' % str(build_dir)
+ str(flutter_checkout_path.join('bin', 'flutter')),
+ 'test',
+ '--local-engine=%s' % str(build_dir),
+ '--local-engine-host=host_debug_unopt',
]
)
