commit 9c2421512e5747c7952601564676bf1fcbb08906
author Jason Simmons <jsimmons@google.com> Tue Jun 21 17:46:04 2022 +0000
committer CQ Bot Account <flutter-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 21 17:46:04 2022 +0000
tree 1f3e7ddb20321b70cb860d9353e3fe37f9314f1a
parent e240614ee4cebfd94d69f6432a797516dadf7ced

Build the unoptimized engine with both AddressSanitizer and LeakSanitizer flags

This build is used with an engine testing script that sets the detect_leaks
flag to enable LeakSanitizer.  The is_lsan GN flag should therefore be
enabled so that libraries such as ANGLE are configured with LeakSanitizer
support.

Change-Id: Ib16c166e5ac899338bd754fb80f49af626696131
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/31360
Commit-Queue: Jason Simmons <jsimmons@google.com>
Reviewed-by: Dan Field <dnfield@google.com>

recipes/engine/engine_unopt.expected/linux.json

diff --git a/recipes/engine/engine_unopt.expected/linux.json b/recipes/engine/engine_unopt.expected/linux.json
index bc3c744..8369a9f 100644
--- a/recipes/engine/engine_unopt.expected/linux.json
+++ b/recipes/engine/engine_unopt.expected/linux.json
@@ -645,6 +645,7 @@
       "--unoptimized",
       "--prebuilt-dart-sdk",
       "--asan",
+      "--lsan",
       "--dart-debug",
       "--no-lto"
     ],
@@ -681,7 +682,7 @@
         "hostname": "rdbhost"
       }
     },
-    "name": "gn --runtime-mode debug --unoptimized --prebuilt-dart-sdk --asan --dart-debug --no-lto"
+    "name": "gn --runtime-mode debug --unoptimized --prebuilt-dart-sdk --asan --lsan --dart-debug --no-lto"
   },
   {
     "cmd": [],

recipes/engine/engine_unopt.expected/linux_lto.json

diff --git a/recipes/engine/engine_unopt.expected/linux_lto.json b/recipes/engine/engine_unopt.expected/linux_lto.json
index 542d61f..11fd285 100644
--- a/recipes/engine/engine_unopt.expected/linux_lto.json
+++ b/recipes/engine/engine_unopt.expected/linux_lto.json
@@ -645,6 +645,7 @@
       "--unoptimized",
       "--prebuilt-dart-sdk",
       "--asan",
+      "--lsan",
       "--dart-debug"
     ],
     "cwd": "[CACHE]/builder",
@@ -680,7 +681,7 @@
         "hostname": "rdbhost"
       }
     },
-    "name": "gn --runtime-mode debug --unoptimized --prebuilt-dart-sdk --asan --dart-debug"
+    "name": "gn --runtime-mode debug --unoptimized --prebuilt-dart-sdk --asan --lsan --dart-debug"
   },
   {
     "cmd": [],

recipes/engine/engine_unopt.py

diff --git a/recipes/engine/engine_unopt.py b/recipes/engine/engine_unopt.py
index 475ba5f..aa1832e 100644
--- a/recipes/engine/engine_unopt.py
+++ b/recipes/engine/engine_unopt.py
@@ -135,6 +135,7 @@
       '--unoptimized',
       '--prebuilt-dart-sdk',
       '--asan',
+      '--lsan',
       '--dart-debug'
   )
   Build(api, 'host_debug_unopt')