Remove seemingly unnecessary --writable-system when calling AVD.
Bug: https://github.com/flutter/flutter/issues/153445
Change-Id: I085b91bd136db2fd06cd8d35fe0e95f30b303122
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/59180
Reviewed-by: Christopher Fujino <fujino@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
diff --git a/recipe_modules/android_virtual_device/api.py b/recipe_modules/android_virtual_device/api.py
index 94166c2..fde16a2 100644
--- a/recipe_modules/android_virtual_device/api.py
+++ b/recipe_modules/android_virtual_device/api.py
@@ -149,9 +149,16 @@
self.m.step(
'Start Android emulator (%s)' % version,
[
- 'xvfb-run', 'vpython3', avd_script_path, 'start',
- '--no-read-only', '--wipe-data', '--writable-system',
- '--debug-tags', 'all', '--avd-config', avd_config
+ 'xvfb-run',
+ 'vpython3',
+ avd_script_path,
+ 'start',
+ '--no-read-only',
+ '--wipe-data',
+ '--debug-tags',
+ 'all',
+ '--avd-config',
+ avd_config
],
stdout=self.m.raw_io.output_text(add_output_log=True),
infra_step=True,
diff --git a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json
index ce1b99e..586cf40 100644
--- a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json
+++ b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json
@@ -279,7 +279,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -495,7 +494,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -711,7 +709,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json
index 39b759f..cff5d11 100644
--- a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json
+++ b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json
@@ -279,7 +279,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -495,7 +494,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json b/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json
index 99f7228..dee7c16 100644
--- a/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json
+++ b/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json b/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json
index 99f7228..dee7c16 100644
--- a/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json
+++ b/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json
index 7da81e4..b15bd59 100644
--- a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json
+++ b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json
@@ -279,7 +279,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -421,7 +420,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -563,7 +561,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json
index 99f7228..dee7c16 100644
--- a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json
+++ b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json
index 99f7228..dee7c16 100644
--- a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json
+++ b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json
index 35981b0..b8fc27d 100644
--- a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json
+++ b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json
index 35981b0..b8fc27d 100644
--- a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json
+++ b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json
index 59b49f8..e96f067 100644
--- a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json
+++ b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json
index 59b49f8..e96f067 100644
--- a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json
+++ b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json
@@ -276,7 +276,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
@@ -782,7 +781,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipes/devicelab/devicelab_drone.expected/emulator-test.json b/recipes/devicelab/devicelab_drone.expected/emulator-test.json
index b25b0dd..e4ed5fd 100644
--- a/recipes/devicelab/devicelab_drone.expected/emulator-test.json
+++ b/recipes/devicelab/devicelab_drone.expected/emulator-test.json
@@ -679,7 +679,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
diff --git a/recipes/packages/packages.expected/emulator-test.json b/recipes/packages/packages.expected/emulator-test.json
index 24962ca..b5e61f9 100644
--- a/recipes/packages/packages.expected/emulator-test.json
+++ b/recipes/packages/packages.expected/emulator-test.json
@@ -835,7 +835,6 @@
"start",
"--no-read-only",
"--wipe-data",
- "--writable-system",
"--debug-tags",
"all",
"--avd-config",
