flutter update-packages in release devicelab

use update-packages instead of doctor on release branches--slower, but will
guarantee all pub deps are present and up to date

BUG=https://github.com/flutter/flutter/issues/78642

Change-Id: I5f618a837ea2d5b116251b51ccaee321a003731b
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/11261
Commit-Queue: Christopher Fujino <fujino@google.com>
Reviewed-by: Godofredo Contreras <godofredoc@google.com>
diff --git a/recipes/devicelab/devicelab_drone_1_26_0.expected/basic.json b/recipes/devicelab/devicelab_drone_1_26_0.expected/basic.json
index 40d43a0..6a84a8a 100644
--- a/recipes/devicelab/devicelab_drone_1_26_0.expected/basic.json
+++ b/recipes/devicelab/devicelab_drone_1_26_0.expected/basic.json
@@ -184,7 +184,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -204,7 +204,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -258,7 +258,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_26_0.expected/post-submit.json b/recipes/devicelab/devicelab_drone_1_26_0.expected/post-submit.json
index 6bffd01..c24ba74 100644
--- a/recipes/devicelab/devicelab_drone_1_26_0.expected/post-submit.json
+++ b/recipes/devicelab/devicelab_drone_1_26_0.expected/post-submit.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -259,7 +259,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_26_0.expected/upload-metrics-mac.json b/recipes/devicelab/devicelab_drone_1_26_0.expected/upload-metrics-mac.json
index b39b525..2a3be95 100644
--- a/recipes/devicelab/devicelab_drone_1_26_0.expected/upload-metrics-mac.json
+++ b/recipes/devicelab/devicelab_drone_1_26_0.expected/upload-metrics-mac.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -256,7 +256,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-chromium-mac.json b/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-chromium-mac.json
index 8fe18b2..7935808 100644
--- a/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-chromium-mac.json
+++ b/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-chromium-mac.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -256,7 +256,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-devicelab.json b/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-devicelab.json
index 8fe18b2..7935808 100644
--- a/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-devicelab.json
+++ b/recipes/devicelab/devicelab_drone_1_26_0.expected/xcode-devicelab.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -256,7 +256,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_26_0.py b/recipes/devicelab/devicelab_drone_1_26_0.py
index 857c129..129799e 100644
--- a/recipes/devicelab/devicelab_drone_1_26_0.py
+++ b/recipes/devicelab/devicelab_drone_1_26_0.py
@@ -58,7 +58,7 @@
     # git_branch is set only when the build was triggered by buildbucket.
     runner_params.extend(['--git-branch', git_branch])
   with api.context(env=env, env_prefixes=env_prefixes, cwd=devicelab_path):
-    api.step('flutter doctor', ['flutter', 'doctor'])
+    api.step('flutter update-packages', ['flutter', 'update-packages'])
     api.step('pub get', ['pub', 'get'])
     dep_list = {d['dependency']: d.get('version') for d in deps}
     if dep_list.has_key('xcode'):
diff --git a/recipes/devicelab/devicelab_drone_1_27_0.expected/basic.json b/recipes/devicelab/devicelab_drone_1_27_0.expected/basic.json
index 40d43a0..6a84a8a 100644
--- a/recipes/devicelab/devicelab_drone_1_27_0.expected/basic.json
+++ b/recipes/devicelab/devicelab_drone_1_27_0.expected/basic.json
@@ -184,7 +184,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -204,7 +204,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -258,7 +258,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_27_0.expected/post-submit.json b/recipes/devicelab/devicelab_drone_1_27_0.expected/post-submit.json
index 6bffd01..c24ba74 100644
--- a/recipes/devicelab/devicelab_drone_1_27_0.expected/post-submit.json
+++ b/recipes/devicelab/devicelab_drone_1_27_0.expected/post-submit.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -259,7 +259,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_27_0.expected/upload-metrics-mac.json b/recipes/devicelab/devicelab_drone_1_27_0.expected/upload-metrics-mac.json
index b591d71..4955bfb 100644
--- a/recipes/devicelab/devicelab_drone_1_27_0.expected/upload-metrics-mac.json
+++ b/recipes/devicelab/devicelab_drone_1_27_0.expected/upload-metrics-mac.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -256,7 +256,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-chromium-mac.json b/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-chromium-mac.json
index a0405d5..18c555d 100644
--- a/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-chromium-mac.json
+++ b/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-chromium-mac.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -256,7 +256,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-devicelab.json b/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-devicelab.json
index a0405d5..18c555d 100644
--- a/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-devicelab.json
+++ b/recipes/devicelab/devicelab_drone_1_27_0.expected/xcode-devicelab.json
@@ -185,7 +185,7 @@
   {
     "cmd": [
       "flutter",
-      "doctor"
+      "update-packages"
     ],
     "cwd": "[CLEANUP]/tmp_tmp_1/flutter sdk/dev/devicelab",
     "env": {
@@ -205,7 +205,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor"
+    "name": "flutter update-packages"
   },
   {
     "cmd": [
@@ -256,7 +256,7 @@
         "[CLEANUP]/tmp_tmp_2/vpython"
       ]
     },
-    "name": "flutter doctor (2)"
+    "name": "flutter doctor"
   },
   {
     "cmd": [
diff --git a/recipes/devicelab/devicelab_drone_1_27_0.py b/recipes/devicelab/devicelab_drone_1_27_0.py
index 857c129..129799e 100644
--- a/recipes/devicelab/devicelab_drone_1_27_0.py
+++ b/recipes/devicelab/devicelab_drone_1_27_0.py
@@ -58,7 +58,7 @@
     # git_branch is set only when the build was triggered by buildbucket.
     runner_params.extend(['--git-branch', git_branch])
   with api.context(env=env, env_prefixes=env_prefixes, cwd=devicelab_path):
-    api.step('flutter doctor', ['flutter', 'doctor'])
+    api.step('flutter update-packages', ['flutter', 'update-packages'])
     api.step('pub get', ['pub', 'get'])
     dep_list = {d['dependency']: d.get('version') for d in deps}
     if dep_list.has_key('xcode'):