commit d2846f227ac5af27d8c3859e487afe2bd2ecf216
author Godofredo Contreras <godofredoc@google.com> Wed May 13 01:07:47 2020 +0000
committer CQ Bot Account <flutter-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 13 01:07:47 2020 +0000
tree 95e9e9259fef2725c2951de62f91fa1fd86d66b4
parent 0300496be45991fb00960b57656c0329557678dc

Revert "Revert "downloading chrome and chromedriver from the cipd packages before running felt test on Linux""

This reverts commit 940b77924da86ce1576b2d2720bdedd7c5624025.

Reason for revert: Autoroller have rolled the dependencies.

Change-Id: I02cc5918c39ef78bcd84d5236a0b22d65f341d91
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/2820
Commit-Queue: Nurhan Turgut <nurhan@google.com>
Reviewed-by: Nurhan Turgut <nurhan@google.com>

recipes/web_engine.py

diff --git a/recipes/web_engine.py b/recipes/web_engine.py
index e412745..0990f3c 100644
--- a/recipes/web_engine.py
+++ b/recipes/web_engine.py
@@ -15,6 +15,7 @@
     'build/goma',
     'depot_tools/gclient',
     'depot_tools/gsutil',
+    'recipe_engine/cipd',
     'recipe_engine/file',
     'recipe_engine/path',
     'recipe_engine/context',
@@ -86,6 +87,30 @@
   return api.path['cache'].join('builder', 'src')
 
 
+def DownloadChromeAndDriver(api):
+  checkout = GetCheckoutPath(api)
+  # Download a specific version of chrome-linux before running Flutter Web
+  # tests.
+  # Chrome uses binary numbers for archiving different versions of the browser.
+  # The binary 741412 has major version 82. It is tested in both headless and
+  # no-headless mode of Chrome Driver for integration tests.
+  # Please make sure to also change the following lock file when updating the
+  # recipe:
+  # flutter/engine/blob/master/lib/web_ui/dev/browser_lock.yaml#L4
+  chrome_path = checkout.join('flutter', 'lib', 'web_ui', '.dart_tool',
+                              'chrome','741412')
+  pkgs = api.cipd.EnsureFile()
+  pkgs.add_package('flutter_internal/browsers/chrome-linux', 'latest')
+  api.cipd.ensure(chrome_path, pkgs)
+  # Download the driver fort the same version of chrome-linux.
+  chrome_driver_path = checkout.join('flutter', 'lib', 'web_ui', '.dart_tool',
+                                     'drivers','chrome')
+  pkgdriver = api.cipd.EnsureFile()
+  pkgdriver.add_package('flutter_internal/browser-drivers/chromedriver-linux',
+                        'latest')
+  api.cipd.ensure(chrome_driver_path, pkgdriver)
+
+
 def RunSteps(api, properties, env_properties):
   """Steps to checkout flutter engine and execute web tests."""
   cache_root = api.path['cache'].join('builder')
@@ -105,7 +130,8 @@
   env = {
       'GOMA_DIR': api.goma.goma_dir,
       'ANDROID_HOME': str(android_home),
-      'CHROME_NO_SANDBOX': 'true'
+      'CHROME_NO_SANDBOX': 'true',
+      'ENGINE_PATH': cache_root
   }
   env_prefixes = {'PATH': [dart_bin]}
 
@@ -145,6 +171,8 @@
       felt_licenses = copy.deepcopy(felt_cmd)
       felt_licenses.append('check-licenses')
       api.step('felt licenses', felt_licenses)
+      if api.platform.is_linux:
+        DownloadChromeAndDriver(api)
       felt_test = copy.deepcopy(felt_cmd)
       felt_test.append('test')
       felt_test.extend(additional_args)