commit e193ceaf9292f286705f635bbabe7828ca9f8f15
author Godofredo Contreras <godofredoc@google.com> Thu Feb 11 22:50:42 2021 +0000
committer CQ Bot Account <flutter-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 11 22:50:42 2021 +0000
tree e23ee17cb08394a04620ef3d0eb50f2b55eb43d9
parent c2486343e8dedc3de49ebac27dc601cbf79ce13d

Install vpython dependency on random tmp folder.

This is to prevent vpython from being killed by mac catalina malware
scanner.

Change-Id: Ia9c4dc505df4b79331a637312cd0001ba8d92636
Bug: https://github.com/flutter/flutter/issues/68322
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/10580
Reviewed-by: Casey Hillers <chillers@google.com>
Commit-Queue: Godofredo Contreras <godofredoc@google.com>

recipe_modules/flutter_deps/api.py

diff --git a/recipe_modules/flutter_deps/api.py b/recipe_modules/flutter_deps/api.py
index 3254855..151ab91 100644
--- a/recipe_modules/flutter_deps/api.py
+++ b/recipe_modules/flutter_deps/api.py
@@ -180,7 +180,7 @@
   def vpython(self, env, env_prefixes, version):
     """Installs vpython."""
     version = version or 'latest'
-    vpython_path = self.m.path['cache'].join('vpython')
+    vpython_path = self.m.path.mkdtemp().join('vpython')
     vpython = self.m.cipd.EnsureFile()
     vpython.add_package('infra/tools/luci/vpython/${platform}', version)
     self.m.cipd.ensure(vpython_path, vpython)

recipe_modules/flutter_deps/examples/full.expected/basic.json

diff --git a/recipe_modules/flutter_deps/examples/full.expected/basic.json b/recipe_modules/flutter_deps/examples/full.expected/basic.json
index c5f4b0d..2676cba 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/basic.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/basic.json
@@ -242,7 +242,7 @@
       "cipd",
       "ensure",
       "-root",
-      "[CACHE]/vpython",
+      "[CLEANUP]/tmp_tmp_1/vpython",
       "-ensure-file",
       "infra/tools/luci/vpython/${platform} v6",
       "-max-threads",

recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json

diff --git a/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json b/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json
index c2292fe..e52b4dc 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/flutter_engine.json
@@ -242,7 +242,7 @@
       "cipd",
       "ensure",
       "-root",
-      "[CACHE]/vpython",
+      "[CLEANUP]/tmp_tmp_1/vpython",
       "-ensure-file",
       "infra/tools/luci/vpython/${platform} v6",
       "-max-threads",

recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json

diff --git a/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json b/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json
index c5f4b0d..2676cba 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/goldTryjob.json
@@ -242,7 +242,7 @@
       "cipd",
       "ensure",
       "-root",
-      "[CACHE]/vpython",
+      "[CLEANUP]/tmp_tmp_1/vpython",
       "-ensure-file",
       "infra/tools/luci/vpython/${platform} v6",
       "-max-threads",

recipe_modules/flutter_deps/examples/full.expected/mac.json

diff --git a/recipe_modules/flutter_deps/examples/full.expected/mac.json b/recipe_modules/flutter_deps/examples/full.expected/mac.json
index af91543..013606b 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/mac.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/mac.json
@@ -242,7 +242,7 @@
       "cipd",
       "ensure",
       "-root",
-      "[CACHE]/vpython",
+      "[CLEANUP]/tmp_tmp_1/vpython",
       "-ensure-file",
       "infra/tools/luci/vpython/${platform} v6",
       "-max-threads",

recipe_modules/flutter_deps/examples/full.expected/with-gems.json

diff --git a/recipe_modules/flutter_deps/examples/full.expected/with-gems.json b/recipe_modules/flutter_deps/examples/full.expected/with-gems.json
index ae7c105..59e7a01 100644
--- a/recipe_modules/flutter_deps/examples/full.expected/with-gems.json
+++ b/recipe_modules/flutter_deps/examples/full.expected/with-gems.json
@@ -242,7 +242,7 @@
       "cipd",
       "ensure",
       "-root",
-      "[CACHE]/vpython",
+      "[CLEANUP]/tmp_tmp_1/vpython",
       "-ensure-file",
       "infra/tools/luci/vpython/${platform} v6",
       "-max-threads",