Revert "Generate absl .def file at build time."

This reverts commit b430ce77ccf35c04c66a2a4bb91078b85a3b2f3a.

Reason for revert: This change causes linker errors in absl.dll on my Windows 10 workstation.

This was tested by checking out the CL before this one and confirming that the build completes successfully, then checking out this CL and confirming that it errors.

Please see the full error at the bottom of this description.

Original change's description:
> Generate absl .def file at build time.
>
> Instead of generating absl .def files at roll time, this CL switches
> the build config to generate the required .def file on the fly while
> building.
>
> The advantages are:
>
> 1. No need to re-generate .def files when something external to absl
> changes and affects .def files (e.g. when a new compiler optimization
> it enabled).
> 2. No need to hard-code supported build flavors in the .def generator
> script, resulting in multiple .def files checked-in.
>
> On the other hand, this makes the build slightly slower than it
> is today because reading all absl object files to generate the
> .def file can take a few seconds.
>
> Bug: 1046390
> Change-Id: If3a8fb3dca0ed75dbd85655cff1263853dcc146a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270094
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824844}

---
Full error:
PS C:\src\chromium\src> autoninja -C out/bug absl.dll
"C:\src\depot_tools\ninja.exe" -C out/bug absl.dll -j 1000
ninja: Entering directory `out/bug'
[1/1] Regenerating ninja files
[3/3] LINK(DLL) absl.dll absl.dll.lib absl.dll.pdb
FAILED: absl.dll absl.dll.lib absl.dll.pdb
ninja -t msvc -e environment.x64 -- ..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe /nologo -libpath:..\..\third_party\llvm-build\Release+Asserts\lib\clang\12.0.0\lib\windows -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\VC\Tools\MSVC\14.26.28801\lib\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\Lib\10.0.19041.0\um\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\Lib\10.0.19041.0\ucrt\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\VC\Tools\MSVC\14.26.28801\atlmfc\lib\x64 /IMPLIB:./absl.dll.lib /DLL /OUT:./absl.dll /PDB:./absl.dll.pdb @./absl.dll.rsp
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::unique_ptr<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct,
struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>>::unique_ptr<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct
std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>><1, void>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0>, struct absl::synchronization_internal::ThreadData *>::__tuple_impl<struct std::__1::__tuple_indices<0>, struct absl::synchronization_internal::ThreadData *><0, struct absl::synchronization_internal::ThreadData *, struct absl::synchronization_internal::ThreadData *>(struct std::__1::__tuple_indices<0>, struct std::__1::__tuple_types<struct absl::synchronization_internal::ThreadData *>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, struct absl::synchronization_internal::ThreadData *&&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0, 1>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>::__tuple_impl<struct std::__1::__tuple_indices<0, 1>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>><0,
1, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>,
class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>(struct std::__1::__tuple_indices<0, 1>, struct std::__1::__tuple_types<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>> &&, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *> &&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0, 1, 2>, class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>::__tuple_impl<struct std::__1::__tuple_indices<0, 1, 2>, class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int><0, 1, 2, class absl::string_view,
class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int, char const (&)[2], char const (&)[2], int>(struct std::__1::__tuple_indices<0, 1, 2>, struct std::__1::__tuple_types<class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, char const (&)[2], char const (&)[2], int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::AlphaNum::AlphaNum<16>(struct absl::strings_internal::AlphaNumBuffer<16> const &)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::thread::thread<void (__cdecl &)(int, class absl::base_internal::SpinLock *), int &, class absl::base_internal::SpinLock *&, void>(void (__cdecl &)(int, class absl::base_internal::SpinLock *), int &, class absl::base_internal::SpinLock *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__bind<void
(__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *><void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *, void>(void (__cdecl &)(struct
absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *&&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__compressed_pair<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>>::__compressed_pair<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>><class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&, 1>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__compressed_pair_elem<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, 0, 0>::__compressed_pair_elem<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, 0, 0><class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct,
struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&, void>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::tuple<class
absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>::tuple<class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int><char const (&)[2], char const (&)[2], int, 0, 0>(char const (&)[2], char const (&)[2], int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_leaf<0, class absl::string_view, 0>::__tuple_leaf<0, class absl::string_view, 0><char const (&)[2], void>(char const (&)[2])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[5], char const (&)[4], 0>(char const (&)[5], char const (&)[4])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[6], char const (&)[7], 0>(char const (&)[6], char const (&)[7])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[7], class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, 0>(char const (&)[7], class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>> &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int const>::optional<int const><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int volatile>::optional<int volatile><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int>::optional<int><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int const, 1>::optional_data_dtor_base<int const, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int volatile, 1>::optional_data_dtor_base<int volatile, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int, 1>::optional_data_dtor_base<int, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: too many errors emitted, stopping now (use /errorlimit:0 to see
all errors)
ninja: build stopped: subcommand failed.
---

TBR=brucedawson@chromium.org,mbonadei@chromium.org

Change-Id: Iaf681079a2c786a7e694538b9fddc68d96dd1a3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523240
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#824894}
GitOrigin-RevId: 8ef7555e6de5f7a2057a0346a229340257b169f9
10 files changed
tree: a7dfcfb6cdf84a5f2cf034f2bc2c02d8d61b5081
  1. .github/
  2. absl/
  3. ci/
  4. CMake/
  5. patches/
  6. ABSEIL_ISSUE_TEMPLATE.md
  7. absl.gni
  8. absl_hardening_test.cc
  9. AUTHORS
  10. BUILD.bazel
  11. BUILD.gn
  12. CMakeLists.txt
  13. conanfile.py
  14. CONTRIBUTING.md
  15. FAQ.md
  16. generate_def_files.py
  17. LICENSE
  18. LTS.md
  19. OWNERS
  20. README.chromium
  21. README.md
  22. roll_abseil.py
  23. symbols_arm64_dbg.def
  24. symbols_arm64_rel.def
  25. symbols_x64_dbg.def
  26. symbols_x64_rel.def
  27. symbols_x64_rel_asan.def
  28. symbols_x86_dbg.def
  29. symbols_x86_rel.def
  30. UPGRADES.md
  31. WORKSPACE
README.md

Abseil - C++ Common Libraries

The repository contains the Abseil C++ library code. Abseil is an open-source collection of C++ code (compliant to C++11) designed to augment the C++ standard library.

Table of Contents

About Abseil

Abseil is an open-source collection of C++ library code designed to augment the C++ standard library. The Abseil library code is collected from Google's own C++ code base, has been extensively tested and used in production, and is the same code we depend on in our daily coding lives.

In some cases, Abseil provides pieces missing from the C++ standard; in others, Abseil provides alternatives to the standard for special needs we've found through usage in the Google code base. We denote those cases clearly within the library code we provide you.

Abseil is not meant to be a competitor to the standard library; we've just found that many of these utilities serve a purpose within our code base, and we now want to provide those resources to the C++ community as a whole.

Quickstart

If you want to just get started, make sure you at least run through the Abseil Quickstart. The Quickstart contains information about setting up your development environment, downloading the Abseil code, running tests, and getting a simple binary working.

Building Abseil

Bazel is the official build system for Abseil, which is supported on most major platforms (Linux, Windows, macOS, for example) and compilers. See the quickstart for more information on building Abseil using the Bazel build system.

If you require CMake support, please check the CMake build instructions.

Codemap

Abseil contains the following C++ library components:

  • base Abseil Fundamentals
    The base library contains initialization code and other code which all other Abseil code depends on. Code within base may not depend on any other code (other than the C++ standard library).
  • algorithm
    The algorithm library contains additions to the C++ <algorithm> library and container-based versions of such algorithms.
  • container
    The container library contains additional STL-style containers, including Abseil's unordered “Swiss table” containers.
  • debugging
    The debugging library contains code useful for enabling leak checks, and stacktrace and symbolization utilities.
  • hash
    The hash library contains the hashing framework and default hash functor implementations for hashable types in Abseil.
  • memory
    The memory library contains C++11-compatible versions of std::make_unique() and related memory management facilities.
  • meta
    The meta library contains C++11-compatible versions of type checks available within C++14 and C++17 versions of the C++ <type_traits> library.
  • numeric
    The numeric library contains C++11-compatible 128-bit integers.
  • strings
    The strings library contains a variety of strings routines and utilities, including a C++11-compatible version of the C++17 std::string_view type.
  • synchronization
    The synchronization library contains concurrency primitives (Abseil's absl::Mutex class, an alternative to std::mutex) and a variety of synchronization abstractions.
  • time
    The time library contains abstractions for computing with absolute points in time, durations of time, and formatting and parsing time within time zones.
  • types
    The types library contains non-container utility types, like a C++11-compatible version of the C++17 std::optional type.
  • utility
    The utility library contains utility and helper code.

License

The Abseil C++ library is licensed under the terms of the Apache license. See LICENSE for more information.

Links

For more information about Abseil: