Abseil: Only use Windows .def files with clang

The various .def files used in Windows builds are generated using
llvm-nm and only support being used with the clang compiler. These .def
files can't be used with MSVC, though we are unsure if that's related to
how they are generated by generate_def_files.py or how MSVC consumes
them (i.e. the format it expects for the symbols).

The issue is primarly about the custom libcxx and MSVC's inability to
work correctly with it. //build/config/c++/c++.gni handles this
automatically by disabling the custom libcxx for non-clang (MSVC) builds
by setting use_custom_libcxx = false. However, this causes the .def
symbols to be generated differently (incorrectly), causing link
failures related to too many symbols being exported.

This change helps support using Abseil in ANGLE, particularly standalone
component builds built with MSVC.

This is a workaround until:
1.) EXPORT macros are used (preferred).
OR
2.) generate_def_files.py can generate .def files for both clang and
MSVC, either manually or as part of the build (unpreferred, since the
script itself is a workaround).
Abseil: Only use Windows .def files with clang

The various .def files used in Windows builds are generated using
llvm-nm and only support being used with the clang compiler. These .def
files can't be used with MSVC, though we are unsure if that's related to
how they are generated by generate_def_files.py or how MSVC consumes
them (i.e. the format it expects for the symbols).

The issue is primarly about the custom libcxx and MSVC's inability to
work correctly with it. //build/config/c++/c++.gni handles this
automatically by disabling the custom libcxx for non-clang (MSVC) builds
by setting use_custom_libcxx = false. However, this causes the .def
symbols to be generated differently (incorrectly), causing link
failures related to too many symbols being exported.

This change helps support using Abseil in ANGLE, particularly standalone
component builds built with MSVC.

This is a workaround until:
1.) EXPORT macros are used (preferred).
OR
2.) generate_def_files.py can generate .def files for both clang and
MSVC, either manually or as part of the build (unpreferred, since the
script itself is a workaround).

Bug: 1126524
Test: Manual verification with standalone ANGLE build
Change-Id: Icf071635938f83818b8345b38074c21f362b897c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419155
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809901}
GitOrigin-RevId: 6e043d67ce7f3ebf27b4809a2d48d65eb05156ef
1 file changed
tree: 1bf54cf6099b92d9bf848ee59dd8a180a28237b5
  1. .github/
  2. absl/
  3. ci/
  4. CMake/
  5. patches/
  6. ABSEIL_ISSUE_TEMPLATE.md
  7. absl.gni
  8. absl_hardening_test.cc
  9. AUTHORS
  10. BUILD.bazel
  11. BUILD.gn
  12. CMakeLists.txt
  13. conanfile.py
  14. CONTRIBUTING.md
  15. FAQ.md
  16. generate_def_files.py
  17. LICENSE
  18. LTS.md
  19. OWNERS
  20. README.chromium
  21. README.md
  22. roll_abseil.py
  23. symbols_arm64_dbg.def
  24. symbols_arm64_rel.def
  25. symbols_x64_dbg.def
  26. symbols_x64_rel.def
  27. symbols_x64_rel_asan.def
  28. symbols_x86_dbg.def
  29. symbols_x86_rel.def
  30. UPGRADES.md
  31. WORKSPACE
README.md

Abseil - C++ Common Libraries

The repository contains the Abseil C++ library code. Abseil is an open-source collection of C++ code (compliant to C++11) designed to augment the C++ standard library.

Table of Contents

About Abseil

Abseil is an open-source collection of C++ library code designed to augment the C++ standard library. The Abseil library code is collected from Google's own C++ code base, has been extensively tested and used in production, and is the same code we depend on in our daily coding lives.

In some cases, Abseil provides pieces missing from the C++ standard; in others, Abseil provides alternatives to the standard for special needs we've found through usage in the Google code base. We denote those cases clearly within the library code we provide you.

Abseil is not meant to be a competitor to the standard library; we've just found that many of these utilities serve a purpose within our code base, and we now want to provide those resources to the C++ community as a whole.

Quickstart

If you want to just get started, make sure you at least run through the Abseil Quickstart. The Quickstart contains information about setting up your development environment, downloading the Abseil code, running tests, and getting a simple binary working.

Building Abseil

Bazel is the official build system for Abseil, which is supported on most major platforms (Linux, Windows, macOS, for example) and compilers. See the quickstart for more information on building Abseil using the Bazel build system.

If you require CMake support, please check the CMake build instructions.

Codemap

Abseil contains the following C++ library components:

  • base Abseil Fundamentals
    The base library contains initialization code and other code which all other Abseil code depends on. Code within base may not depend on any other code (other than the C++ standard library).
  • algorithm
    The algorithm library contains additions to the C++ <algorithm> library and container-based versions of such algorithms.
  • container
    The container library contains additional STL-style containers, including Abseil's unordered “Swiss table” containers.
  • debugging
    The debugging library contains code useful for enabling leak checks, and stacktrace and symbolization utilities.
  • hash
    The hash library contains the hashing framework and default hash functor implementations for hashable types in Abseil.
  • memory
    The memory library contains C++11-compatible versions of std::make_unique() and related memory management facilities.
  • meta
    The meta library contains C++11-compatible versions of type checks available within C++14 and C++17 versions of the C++ <type_traits> library.
  • numeric
    The numeric library contains C++11-compatible 128-bit integers.
  • strings
    The strings library contains a variety of strings routines and utilities, including a C++11-compatible version of the C++17 std::string_view type.
  • synchronization
    The synchronization library contains concurrency primitives (Abseil's absl::Mutex class, an alternative to std::mutex) and a variety of synchronization abstractions.
  • time
    The time library contains abstractions for computing with absolute points in time, durations of time, and formatting and parsing time within time zones.
  • types
    The types library contains non-container utility types, like a C++11-compatible version of the C++17 std::optional type.
  • utility
    The utility library contains utility and helper code.

License

The Abseil C++ library is licensed under the terms of the Apache license. See LICENSE for more information.

Links

For more information about Abseil: