Revert "absl: Suppress -Wunused-value for files including internal/flag.h" This reverts commit 4a8fbf724eeccbf66f306afe69b38c7705abe571. Reason for revert: The issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/3181708. Original change's description: > absl: Suppress -Wunused-value for files including internal/flag.h > > Trunk clang warns about this file. > It's not clear yet if the warning is correct. > Suppress it for now -- almost no files depend on this target, > so suppressing the warning should be fairly local and easy to undo. > > Bug: 1251757 > Change-Id: I1cb39bf365da8ab41ff30543d5a086ddac0f8dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179483 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924386} Bug: 1251757 Change-Id: I4e7d22e74023692990bd5936c97f444b4e7c23fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183200 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#925249} NOKEYCHECK=True GitOrigin-RevId: cf0e204caf27fe0a1b4dab40154aac2ac67f359f
diff --git a/absl/flags/BUILD.gn b/absl/flags/BUILD.gn index d2f9f18..a47248b 100644 --- a/absl/flags/BUILD.gn +++ b/absl/flags/BUILD.gn
@@ -114,17 +114,8 @@ ] } -config("absl_flag_internal_config") { - if (is_clang) { - # TODO(crbug.com/1251757): Figure out what to do with this. - cflags = [ "-Wno-unused-value" ] - } -} - - absl_source_set("flag_internal") { sources = [ "internal/flag.cc" ] - public_configs = [ ":absl_flag_internal_config" ] public = [ "internal/flag.h", "internal/sequence_lock.h",