tree 3f94e98e3e8cbcce9c5e15bf165a15dfe02f0086
parent 1e3b0f36308a8058c2a4489b2e1f9a496cc2e39f
author Bruce Dawson <brucedawson@chromium.org> 1599337106 +0000
committer Copybara-Service <copybara-worker@google.com> 1599337264 -0700

Make generate_def_files.py on Windows more robust

It is now possible to run generate_def_files.py on Windows (although the
results don't match those on Linux) but it is error prone. If you run
the script under Python 3 or without dumpbin in the path then it will
fail without a clear explanation. This adds diagnostic messages for
these two conditions.

Bug: 1046390
Change-Id: I8e1d4815c77e3ec9b4edca2a2cb78484ade1fe7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392951
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804616}
GitOrigin-RevId: dc0dfa4e0668b1f85536dba5b328dcbee61277ee