commit e69e814299776604b2294c2c03f629746a63871c
author Mirko Bonadei <mbonadei@chromium.org> Fri Apr 13 14:02:18 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Fri Apr 13 14:02:18 2018 +0000
tree eda54badddd632008c2ecdc44f551a7a5a3964d4
parent 72891c2b3af0edaaa8a3a5ffe1fbdfaa271154f6

Removing exceptions support from Abseil in Chromium.

If Abseil is compiled with -fexceptions ABSL_HAVE_EXCEPTIONS will be
defined and Abseil will be able to throw. Since exceptions are
forbidden in Chromium's code, this CL removes the possibility to
enable them.

Abseil automatically sets ABSL_HAVE_EXCEPTIONS here:
https://cs.chromium.org/chromium/src/third_party/abseil-cpp/absl/base/config.h?l=207&rcl=f4f0f0e2af28098ac58f8548b13d1a1f46d7c846

Bug: webrtc:8821
Change-Id: I82e19abbe62f332173d977b5ea93f9040232572b
Reviewed-on: https://chromium-review.googlesource.com/1012074
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550614}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aad19c86b25c3a47f6566dbe07e74f7c9417f7e5

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 1f0a915..2fb6993 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -179,18 +179,3 @@
     }
   }
 }
-
-config("absl_exceptions_cflags_cc") {
-  # Enable exception handling.
-  if (is_win) {
-    cflags_cc = [
-      "/U_HAS_EXCEPTIONS",
-      "/D_HAS_EXCEPTIONS=1",
-      "/EHsc"
-    ]
-  } else {
-    cflags_cc = [
-      "-fexceptions",
-    ]
-  }
-}

absl/base/BUILD.gn

diff --git a/absl/base/BUILD.gn b/absl/base/BUILD.gn
index d740765..c67297c 100644
--- a/absl/base/BUILD.gn
+++ b/absl/base/BUILD.gn
@@ -170,7 +170,6 @@
 source_set("throw_delegate") {
   configs += [
     "//third_party/abseil-cpp:absl_default_cflags_cc",
-    "//third_party/abseil-cpp:absl_exceptions_cflags_cc",
   ]
   public_configs = [ "//third_party/abseil-cpp:absl_include_config" ]
   sources = [
@@ -215,7 +214,6 @@
   testonly = true
   configs += [
     "//third_party/abseil-cpp:absl_test_cflags_cc",
-    "//third_party/abseil-cpp:absl_exceptions_cflags_cc",
   ]
 
   public_configs = [ "//third_party/abseil-cpp:absl_include_config" ]

absl/types/BUILD.gn

diff --git a/absl/types/BUILD.gn b/absl/types/BUILD.gn
index d3c05e6..3fa2c8d 100644
--- a/absl/types/BUILD.gn
+++ b/absl/types/BUILD.gn
@@ -18,7 +18,6 @@
 source_set("any") {
   configs += [
     "//third_party/abseil-cpp:absl_default_cflags_cc",
-    "//third_party/abseil-cpp:absl_exceptions_cflags_cc",
   ]
   public_configs = [ "//third_party/abseil-cpp:absl_include_config" ]
   public = [
@@ -36,7 +35,6 @@
 source_set("bad_any_cast") {
   configs += [
     "//third_party/abseil-cpp:absl_default_cflags_cc",
-    "//third_party/abseil-cpp:absl_exceptions_cflags_cc",
   ]
   public_configs = [ "//third_party/abseil-cpp:absl_include_config" ]
   sources = [
@@ -86,7 +84,6 @@
 source_set("bad_optional_access") {
   configs += [
     "//third_party/abseil-cpp:absl_default_cflags_cc",
-    "//third_party/abseil-cpp:absl_exceptions_cflags_cc",
   ]
   public_configs = [ "//third_party/abseil-cpp:absl_include_config" ]
   sources = [