tree da0ae5ff5ad515b2ef834aa31ae10a0b82c30dce
parent ce138e2c2d6992b31ff4cd2e955904637785a881
author Jason Simmons <jsimmons@google.com> 1782775079 -0700
committer Jason Simmons <jsimmons@google.com> 1782834601 -0700

Generate bindings for uniforms that are not wrapped in a struct

Glslang no longer assigns bindings to loose uniforms that are not part
of a struct.
(see https://github.com/KhronosGroup/glslang/pull/4066)

However, Flutter depends on the previous behavior.

By default the spirv-cross Metal back end will set the indexes of
uniforms based on the order in which they are used within the shader.
But Flutter's runtime shader API requires that indexes be set based on
where they were declared in the shader.  So ImpellerC's Metal back end
remaps the uniforms to the desired locations by calling the spirv-cross
CompilerMSL::add_msl_resource_binding API.

CompilerMSL::add_msl_resource_binding identifies each uniform by its
binding.  Flutter supports non-struct uniforms on Metal, and thus
Flutter requires that every uniform have a unique binding so that it
can perform the remapping.

This patch restores the legacy behavior where bindings are assigned to
all uniforms regardless of whether they are structs.

Change-Id: I93e730c21772a19e72af8db77247df1184faaee8