)]}' { "commit": "96299d70edba60e5eb88a1efca384bc82392d977", "tree": "df4237d77619219791f0aa31354fa998e66e297f", "parents": [ "b621c4fc29162c69098dce29fed887eac903d516" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Tue Oct 12 10:42:43 2021 -0400" }, "committer": { "name": "Behdad Esfahbod", "email": "behdad@behdad.org", "time": "Tue Oct 12 08:56:54 2021 -0600" }, "message": "Fix Wbitwise-instead-of-logical warnings\n\n`a || b` only evaluates b if a is false. `a | b` always evaluates\nboth a and b. If a and b are of type bool, || is usually what you\nwant, so clang now warns on `|` where both arguments are of type bool.\n\nThis warning fires twice in harfbuzz. In both cases, `|` is used\nintentionally, with a comment explaining this.\n\nSlightly reorder the code a bit to make the compiler happy, and to\nmake it obvious even without a comment that both calls should be evaluated.\n\nNo intended behavior change.\n", "tree_diff": [ { "type": "modify", "old_id": "1e53920f8e023424ea32733ce542fe3c0f37ee47", "old_mode": 33188, "old_path": "src/hb-ot-layout-gpos-table.hh", "new_id": "ac8f6eaf8ced86e13c46578d38144e6732fba983", "new_mode": 33188, "new_path": "src/hb-ot-layout-gpos-table.hh" } ] }