commit a7dd90f519fb7ab046e92ea3b7101c21d5040bbc
author Behdad Esfahbod <behdad@behdad.org> Fri Jun 01 16:07:55 2018 -0700
committer Behdad Esfahbod <behdad@behdad.org> Fri Jun 01 16:10:45 2018 -0700
tree 3c9f67818fb4b5a79aa8487317042da6173aa6c5
parent 7b50bf52f274f75f0b41008e0eab150124ae928a

Revert "Remove HB_DISALLOW_COPY_AND_ASSIGN"

This reverts commit ff92de766bf775bfdd3a01bda94de699180ff86a.

Revert that and remove ASSERT_POD. Let's see which bots are
unhappy with this configuration...

src/hb-map-private.hh

diff --git a/src/hb-map-private.hh b/src/hb-map-private.hh
index 4663446..cad6f0e2 100644
--- a/src/hb-map-private.hh
+++ b/src/hb-map-private.hh
@@ -98,7 +98,6 @@
   };
 
   hb_object_header_t header;
-  ASSERT_POD ();
   bool successful; /* Allocations successful */
   unsigned int population; /* Not including tombstones. */
   unsigned int occupancy; /* Including tombstones. */
@@ -252,7 +251,7 @@
   }
 
   private:
-  HB_DISALLOW_ASSIGN (hb_map_t);
+  HB_DISALLOW_COPY_AND_ASSIGN (hb_map_t);
 };
 
 

src/hb-ot-shape-private.hh

diff --git a/src/hb-ot-shape-private.hh b/src/hb-ot-shape-private.hh
index a540e6a..c217af0 100644
--- a/src/hb-ot-shape-private.hh
+++ b/src/hb-ot-shape-private.hh
@@ -99,7 +99,7 @@
   }
 
   private:
-  HB_DISALLOW_ASSIGN (hb_ot_shape_planner_t);
+  HB_DISALLOW_COPY_AND_ASSIGN (hb_ot_shape_planner_t);
 };
 
 

src/hb-private.hh

diff --git a/src/hb-private.hh b/src/hb-private.hh
index 53dfd80..05f0adb 100644
--- a/src/hb-private.hh
+++ b/src/hb-private.hh
@@ -537,7 +537,11 @@
  */
 
 #define HB_DISALLOW_ASSIGN(TypeName) \
-  void operator=(const TypeName&)
+  void operator=(const TypeName&) = delete
+
+#define HB_DISALLOW_COPY_AND_ASSIGN(TypeName) \
+  TypeName(const TypeName&) = delete; \
+  void operator=(const TypeName&) = delete
 
 /*
  * Static pools

src/hb-set-private.hh

diff --git a/src/hb-set-private.hh b/src/hb-set-private.hh
index 0129af8..323c6f4 100644
--- a/src/hb-set-private.hh
+++ b/src/hb-set-private.hh
@@ -180,7 +180,6 @@
   static_assert (page_t::PAGE_BITS == sizeof (page_t) * 8, "");
 
   hb_object_header_t header;
-  ASSERT_POD ();
   bool successful; /* Allocations successful */
   mutable unsigned int population;
   hb_vector_t<page_map_t, 8> page_map;
@@ -679,7 +678,7 @@
   inline hb_codepoint_t major_start (unsigned int major) const { return major * page_t::PAGE_BITS; }
 
   private:
-  HB_DISALLOW_ASSIGN (hb_set_t);
+  HB_DISALLOW_COPY_AND_ASSIGN (hb_set_t);
 };