commit c0af193c8e25c4f11d23b8893e9ce1c2d2615bb2
author Behdad Esfahbod <behdad@behdad.org> Fri Apr 15 19:26:24 2011 -0400
committer Behdad Esfahbod <behdad@behdad.org> Fri Apr 15 19:26:24 2011 -0400
tree 5bf7375b806df0892affc1b04ff4feb9b4aac349
parent 00bec2c969555e76c3f84650a1d3c45308e585ad

Change buffer default properties to invalid

This includes HB_DIRECTION_INVALID and HB_SCRIPT_INVALID.

The INVALID will cause a "guess whatever from the text" in hb_shape().
While it's not ideal, it works better than the previous defaults at
least (HB_DIRECTION_LTR and HB_SCRIPT_COMMON).

src/hb-view.c

diff --git a/src/hb-view.c b/src/hb-view.c
index 87d9b30..d7e41fd 100644
--- a/src/hb-view.c
+++ b/src/hb-view.c
@@ -355,10 +355,8 @@
   hb_buffer_add_utf8 (hb_buffer, text, len, 0, len);
   if (script)
     hb_buffer_set_script (hb_buffer, hb_script_from_string (script));
-  else
-    hb_buffer_set_script (hb_buffer, HB_SCRIPT_INVALID);
-  hb_buffer_set_direction (hb_buffer, HB_DIRECTION_INVALID);
-  hb_buffer_set_language (hb_buffer, hb_language_from_string (language));
+  if (language)
+    hb_buffer_set_language (hb_buffer, hb_language_from_string (language));
 
   hb_shape (hb_font, hb_face, hb_buffer, features, num_features);