commit d0b657379bbe63602953412d6bc944b2a0f430eb
author Behdad Esfahbod <behdad@behdad.org> Thu Aug 06 18:34:47 2009 -0400
committer Behdad Esfahbod <behdad@behdad.org> Mon Nov 02 14:40:34 2009 -0500
tree a3d40cb4b319e64bed0621330c6cd908f904e635
parent 82199868fb036b63799af761762225d45d36f575

[HB] Fix various XXX issues

src/hb-open-type-private.hh

diff --git a/src/hb-open-type-private.hh b/src/hb-open-type-private.hh
index 08dd075..494a99d 100644
--- a/src/hb-open-type-private.hh
+++ b/src/hb-open-type-private.hh
@@ -298,9 +298,16 @@
 #define SANITIZE_OBJ(X) SANITIZE_MEM(&(X), sizeof (X))
 #define SANITIZE_GET_SIZE() SANITIZE_SELF() && SANITIZE_MEM (this, this->get_size ())
 
-#define SANITIZE_MEM(B,L) HB_LIKELY (context->start <= CONST_CHARP(B) && CONST_CHARP(B) + (L) <= context->end) /* XXX overflow */
+/* TODO Optimize this if L is fixed (gcc magic) */
+#define SANITIZE_MEM(B,L) \
+	HB_LIKELY (context->start <= CONST_CHARP(B) && \
+		   CONST_CHARP(B) < context->end && \
+		   context->end - CONST_CHARP(B) < (L))
 
-#define NEUTER(Var, Val) (SANITIZE_OBJ (Var) && _hb_sanitize_edit (context, CONST_CHARP(&(Var)), sizeof (Var)) && ((Var) = (Val), true))
+#define NEUTER(Var, Val) \
+	(SANITIZE_OBJ (Var) && \
+	 _hb_sanitize_edit (context, CONST_CHARP(&(Var)), sizeof (Var)) && \
+	 ((Var) = (Val), true))
 
 
 /* Template to sanitize an object. */
@@ -311,7 +318,7 @@
     hb_sanitize_context_t context;
     bool sane;
 
-    /* XXX is_sane() stuff */
+    /* TODO is_sane() stuff */
 
   retry:
 #if HB_DEBUG

src/hb-ot-layout-gdef-private.hh

diff --git a/src/hb-ot-layout-gdef-private.hh b/src/hb-ot-layout-gdef-private.hh
index b1b034b..fcf85c2 100644
--- a/src/hb-ot-layout-gdef-private.hh
+++ b/src/hb-ot-layout-gdef-private.hh
@@ -99,7 +99,7 @@
   private:
   inline int get_caret_value (hb_ot_layout_context_t *context, hb_codepoint_t glyph_id) const
   {
-    /* XXX vertical */
+    /* TODO vertical */
     return context->font->x_scale * coordinate / 0x10000;
   }
 
@@ -141,7 +141,7 @@
 
   inline int get_caret_value (hb_ot_layout_context_t *context, hb_codepoint_t glyph_id) const
   {
-    /* XXX vertical */
+    /* TODO vertical */
     return context->font->x_scale * coordinate / 0x10000 +
 	   ((this+deviceTable).get_delta (context->font->x_ppem) << 6);
   }
@@ -163,7 +163,6 @@
 
 struct CaretValue
 {
-  /* XXX  we need access to a load-contour-point vfunc here */
   int get_caret_value (hb_ot_layout_context_t *context, hb_codepoint_t glyph_id) const
   {
     switch (u.format) {