)]}' { "commit": "637e8c503ade7452427b9c6bd3ba362d2d195453", "tree": "7778e09b1287b41a3dbbaebd1b871653cdf856e1", "parents": [ "4642f4676ebfbbd4cb6474b2c153e26dfbc44b20" ], "author": { "name": "Nikolas Klauser", "email": "nikolasklauser@berlin.de", "time": "Thu Mar 03 12:10:30 2022 +0100" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 03 04:22:47 2022 -0800" }, "message": "[libc++] Use -I instead of -isystem to include headers in the test suite\n\nUsing -isystem marks the headers as system headers, which means that we\ndon\u0027t actually get all the warnings that we\u0027d normally get if we included\nthe headers as user headers.\n\nThe goal of the test suite is normally to mirror as closely as possible\nhow users would use the library. Technically, this change goes against\nthat philosophy, since users should be using `-isystem` (if they ever\nneed to specify the libc++ path explicitly, which should be a rare\noccurence). However, I believe fishing out additional warnings from\nthe headers provides more value, hence this change. Ideally, we\u0027d be\nable to still use `-isystem`, but instruct Clang to still emit warnings\nfrom the libc++ headers (e.g. we could tell Clang to emit warnings in\nany file inside `\u003c...\u003e/usr/include/c++/v1`).\n\nReviewed By: #libc, ldionne, #libc_abi\n\nSpies: Mordante, EricWF, mstorsjo, mgorny, aheejin, arichardson, philnik, jloser, libcxx-commits\n\nDifferential Revision: https://reviews.llvm.org/D118616\n\nGitOrigin-RevId: bd44174547aaf0b491039a5a71d967e1471b6d87\n", "tree_diff": [ { "type": "modify", "old_id": "9239c550b744b5e766eda111af8afda1345051f8", "old_mode": 33188, "old_path": "test/configs/apple-libc++abi-backdeployment.cfg.in", "new_id": "06dd50310729d22a027a7793d481fa877535e64a", "new_mode": 33188, "new_path": "test/configs/apple-libc++abi-backdeployment.cfg.in" }, { "type": "modify", "old_id": "4d0df23e0d67559ffe57c6e67ac495a10b9fe976", "old_mode": 33188, "old_path": "test/configs/apple-libc++abi-shared.cfg.in", "new_id": "cf65ce44cd9559b60054e1a540fd53032bb76094", "new_mode": 33188, "new_path": "test/configs/apple-libc++abi-shared.cfg.in" }, { "type": "modify", "old_id": "06d9aca508a46255bd3b7a2d31b7e3f3c0c66607", "old_mode": 33188, "old_path": "test/configs/ibm-libc++abi-shared.cfg.in", "new_id": "64fc4f234b843beca949c1ef7dcc5caa34a8a07b", "new_mode": 33188, "new_path": "test/configs/ibm-libc++abi-shared.cfg.in" } ] }