commit 25d2d47f86b0164ad9d136463f80855027edeaf7
author Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Mon Jan 31 10:25:10 2011 -0600
committer Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Mon Jan 31 10:25:10 2011 -0600
tree c32535bf4220cadef012dfbe1407b90fb5fce1ce
parent 4c0eaee5c6cd35e7726ef8131c40bf46ae807f3c

[devel] updated the commentary in pngpriv.h about PNG_UNUSED().

ANNOUNCE

diff --git a/ANNOUNCE b/ANNOUNCE
index 9be49af..4069e20 100644
--- a/ANNOUNCE
+++ b/ANNOUNCE
@@ -1,5 +1,5 @@
 
-Libpng 1.5.1rc02 - January 30, 2011
+Libpng 1.5.1rc02 - January 31, 2011
 
 This is not intended to be a public release.  It will be replaced
 within a few weeks by a public version or by another test version.
@@ -115,13 +115,13 @@
     architectures.
   Added transform tests to pngvalid and simplified the arguments.
 
-Version 1.5.1rc01 [January 30, 2011]
+Version 1.5.1rc01 [January 31, 2011]
   No changes.
 
-Version 1.5.1rc02 [January 30, 2011]
+Version 1.5.1rc02 [January 31, 2011]
   Added a request in the manual that applications do not use "png_" or
     "PNG_" to begin any of their own symbols.
-  Changed PNG_UNUSED to "(void)param;"
+  Changed PNG_UNUSED to "(void)param;" and updated the commentary in pngpriv.h
 
 Send comments/corrections/commendations to png-mng-implement at lists.sf.net:
 (subscription required; visit

CHANGES

diff --git a/CHANGES b/CHANGES
index 10e99ac..121e517 100644
--- a/CHANGES
+++ b/CHANGES
@@ -3231,13 +3231,13 @@
     architectures.
   Added transform tests to pngvalid and simplified the arguments.
 
-Version 1.5.1rc01 [January 30, 2011]
+Version 1.5.1rc01 [January 31, 2011]
   No changes.
 
-Version 1.5.1rc02 [January 30, 2011]
+Version 1.5.1rc02 [January 31, 2011]
   Added a request in the manual that applications do not use "png_" or
     "PNG_" to begin any of their own symbols.
-  Changed PNG_UNUSED to "(void)param;"
+  Changed PNG_UNUSED to "(void)param;" and updated the commentary in pngpriv.h
 
 Send comments/corrections/commendations to png-mng-implement at lists.sf.net
 (subscription required; visit

pngpriv.h

diff --git a/pngpriv.h b/pngpriv.h
index d3903a9..30ac004 100644
--- a/pngpriv.h
+++ b/pngpriv.h
@@ -83,33 +83,14 @@
 #  define PNG_MAX_MALLOC_64K
 #endif
 
-/* Unused formal parameter errors are removed using the following macro
- * which is expected to have no bad effects on performance.  Note that
- * if you replace it with something other than whitespace, you must include
- * the terminating semicolon.  Also note that some of these might not
- * work when "param" is a structure, but that is never the case in libpng.
+/* Unused formal parameter warnings are silenced using the following macro
+ * which is expected to have no bad effects on performance (optimizing
+ * compilers will probably remove it entirely).  Note that if you replace
+ * it with something other than whitespace, you must include the terminating
+ * semicolon.
  */
 #define PNG_UNUSED(param) (void)param;
 
-#if 0 /* Possibilities discussed on png-mng-implement, starting 27 Jan 2011 */
-#ifndef PNG_UNUSED                                 /* "best" but complex */
- #if defined(__GNUC__) || defined(_MSC_VER)
- #  define PNG_UNUSED(param) (void)param;
- #else
- #  define PNG_UNUSED(param)
- #endif
-#define PNG_UNUSED(param) {if(param){}}
-#define PNG_UNUSED(param) param = param;            /* What we used before */
-#define PNG_UNUSED(param) {(void)param;}            /* Visual C complains */
-#define PNG_UNUSED(param) if(param);                /* gcc-4.2 complains */
-#define PNG_UNUSED(param) if(param){}               /* more brackets nicer */
-#define PNG_UNUSED(param) ((void)(param ? 0 : 0));  /* 0:0 might be seen */
-#define PNG_UNUSED(param) {if(&param){}}            /* gcc-4 complains */
-#define PNG_UNUSED(param) {if(&param-&param){}}     /* No comment. */
-#define PNG_UNUSED(param) /* generates smallest (no) code but emits warning */
-#endif /* 0 */
-#endif /* PNG_UNUSED */
-
 /* Just a little check that someone hasn't tried to define something
  * contradictory.
  */