commit bf3293a3cb9ec31f73cde4f5054086ae3adee74c
author Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Fri Jan 28 15:14:43 2011 -0600
committer Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Fri Jan 28 15:14:43 2011 -0600
tree 7d724bf0ecf3966658bace908b30c3e0d0ce5f85
parent 4e7c47fb7356f23d218a8f2ac8ef5ca660affb9c

[devel] Fixed comments around PNG_UNUSED macro definition in pngpriv.h

pngpriv.h

diff --git a/pngpriv.h b/pngpriv.h
index afc36b8..70eac1f 100644
--- a/pngpriv.h
+++ b/pngpriv.h
@@ -86,26 +86,28 @@
 /* Unused formal parameter errors are removed using the following macro
  * which is expected to have no bad effects on performance.  Note that
  * if you replace it with something other than whitespace, you must include
- * the terminating semicolon.
+ * the terminating semicolon.  Also note that some of these might not
+ * work when "param" is a structure, but that is never the case in libpng.
  */
-#ifndef PNG_UNUSED
-#  define PNG_UNUSED(param) {if(param){}}
-/* Other possiblities being discussed on png-mng-implement, Jan 2011 */
-/* #define PNG_UNUSED(param) param = param; */         /* What we used before */
-/* #define PNG_UNUSED(param) {(void)param;} */         /* Visual C complains */
-/* #define PNG_UNUSED(param) if(param);     */         /* gcc-4.2 complains */
-/* #define PNG_UNUSED(param) if(param){}    */
-/* #define PNG_UNUSED(param) ((void)(param ? 0 : 0)); */ /* 0:0 might be seen */
-/* #define PNG_UNUSED(param) {if(&param){}} */         /* gcc-4 complains */
-/* #define PNG_UNUSED(param) {if(&param-&param){}} */  /* No comment. */
-/*
- * #if defined(__GNUC__) || defined(_MSC_VER)
- * #  define UNUSED(param) (void)param;
- * #else
- * #  define UNUSED(param)
- * #endif
-*/
-#endif
+#define PNG_UNUSED(param) {if(param){}}
+
+#if 0 /* Possibilities discussed on png-mng-implement, starting 27 Jan 2011 */
+#ifndef PNG_UNUSED                                 /* "best" but complex */
+ #if defined(__GNUC__) || defined(_MSC_VER)
+ #  define PNG_UNUSED(param) (void)param;
+ #else
+ #  define PNG_UNUSED(param)
+ #endif
+#define PNG_UNUSED(param) param = param;            /* What we used before */
+#define PNG_UNUSED(param) {(void)param;}            /* Visual C complains */
+#define PNG_UNUSED(param) if(param);                /* gcc-4.2 complains */
+#define PNG_UNUSED(param) if(param){}               /* more brackets nicer */
+#define PNG_UNUSED(param) ((void)(param ? 0 : 0));  /* 0:0 might be seen */
+#define PNG_UNUSED(param) {if(&param){}}            /* gcc-4 complains */
+#define PNG_UNUSED(param) {if(&param-&param){}}     /* No comment. */
+#define PNG_UNUSED(param) /* generates smallest (no) code but emits warning */
+#endif /* 0 */
+#endif /* PNG_UNUSED */
 
 /* Just a little check that someone hasn't tried to define something
  * contradictory.