tree 832f6f2b1f7776fb2233b993a0b3f68be394b79e
parent a524555c987fec2c16417d2f58c8713efcbe11a9
author Nathan Hjelm <hjelmn@google.com> 1623379904 -0600
committer Nathan Hjelm <hjelmn@google.com> 1623380184 -0600

core: ensure that all devices are properly cleaned up on libusb_exit

When cleaning up the context on libusb_exit the last step is to to call
hotplug_exit. This function took one pass over the devices and released any
devices where the reference count had reached 0. All remaining devices
were assumed to have leaked references and a warning message was printed
out. Unfortunately, this cleanup was too simplistic. It ignored the
references created when a device was the parent of another device (which
takes a reference). This reference is released when the child device is
released.

To ensure that we do not erroneously warn about devices with leftover
references the code now loops over the device list until no more devices
have a single reference. This ensures that we will eventually remove
all devices with no external references.

Fixes #924

Signed-off-by: Nathan Hjelm <hjelmn@google.com>