tree 931ee516fe8c35b1361052d21a9ce57335cebaa3
parent fc5132ca74d4a6fc9a8ae942451bc107b25497be
author Chris Dickens <christopher.a.dickens@gmail.com> 1588038222 -0700
committer Chris Dickens <christopher.a.dickens@gmail.com> 1588038222 -0700

core: Fix some minor inconsistencies in API and coding

All of the API functions should take the typedef'ed versions of the
opaque libusb structures, but some recent additions to the API did not
follow this convention. Fix this by making the changes to the
declarations and definitions of the functions.

Make the placement of the asterisk in pointer variable declarations
consistent (always with the variable name, not the type).

Remove some unnecessary casts and initializations relating to
dynamically allocated memory. While at it, make casts within the core
library consistent in style with no space after the closing parenthesis
of the cast. Most of the core already used this style.

When using the 'sizeof' operator, dereference the pointer instead of
using the type.  Most of the core was already doing this, so fix up the
few places that weren't.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>