commit 2217022b7d1142738656d891e00b3d2d9179b796
author Thomas Klausner <tk@giga.or.at> Mon Aug 14 10:55:44 2017 +0200
committer Thomas Klausner <tk@giga.or.at> Mon Aug 14 10:55:44 2017 +0200
tree 35f06b6ab28eaf7bceaec3de454bf2c23581a760
parent f0b8ddaabe53b2ea34ea115dfba7879b9e7a29f0

Fix double free().

Found by Brian 'geeknik' Carpenter using AFL.

THANKS

diff --git a/THANKS b/THANKS
index be0cca9..a80ee1d 100644
--- a/THANKS
+++ b/THANKS
@@ -12,6 +12,7 @@
 Benjamin Gilbert <bgilbert@backtick.net>
 Boaz Stolk <bstolk@aweta.nl>
 Bogdan <bogiebog@gmail.com>
+Brian 'geeknik' Carpenter <geeknik@protonmail.ch>
 Chris Nehren <cnehren+libzip@pobox.com>
 Coverity <info@coverity.com>
 Dane Springmeyer <dane.springmeyer@gmail.com>

lib/zip_dirent.c

diff --git a/lib/zip_dirent.c b/lib/zip_dirent.c
index a369900..e5a7cc9 100644
--- a/lib/zip_dirent.c
+++ b/lib/zip_dirent.c
@@ -579,9 +579,6 @@
     }
 
     if (!_zip_dirent_process_winzip_aes(zde, error)) {
-	if (!from_buffer) {
-	    _zip_buffer_free(buffer);
-	}
 	return -1;
     }