commit 7f433bef6cfaa2b7faf3d4d973dea5e7477b110f
author Dieter Baron <dillo@nih.at> Sat Oct 13 18:55:35 2012 +0200
committer Dieter Baron <dillo@nih.at> Sat Oct 13 18:55:35 2012 +0200
tree 3a0e425f7e6ee92179e6b24db4959521a868d677
parent 0ad8e84ffe11fa0b17a175c066032ff30f995206

Check for off_t overflow.

lib/zip_extra_field.c

diff --git a/lib/zip_extra_field.c b/lib/zip_extra_field.c
index 9b9e399..d29cd76 100644
--- a/lib/zip_extra_field.c
+++ b/lib/zip_extra_field.c
@@ -262,6 +262,7 @@
     struct zip_extra_field *prev, *next;
     
     ef_head = prev = ef;
+    prev = NULL;
     
     while (ef) {
         if (ZIP_EF_IS_INTERNAL(ef->id)) {
@@ -336,7 +337,6 @@
 	return 0;
 
 
-    /* XXX: check for off_t overflow */
     if (fseeko(za->zp, (off_t)(e->orig->offset + 26), SEEK_SET) < 0) {
 	_zip_error_set(&za->error, ZIP_ER_SEEK, errno);
 	return -1;