commit 0d502c3511ab3b1c8acb129fb3af836727b8092d
author Matt Caswell <matt@openssl.org> Mon Feb 12 17:47:50 2018 +0000
committer Matt Caswell <matt@openssl.org> Thu Feb 15 15:24:47 2018 +0000
tree 6c2c515767d0c9f10b63e2acd79343408676fa34
parent bc2a0dd283c0f61df572b8c2aaf3bfc2dd4b7571

Check the return code from ASN1_TIME_diff()

The function can fail so we should check the return code.

Found by Coverity

Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/5339)

apps/ca.c

diff --git a/apps/ca.c b/apps/ca.c
index a416f36..26c0778 100644
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -1706,7 +1706,9 @@
 
     if (enddate != NULL) {
         int tdays;
-        ASN1_TIME_diff(&tdays, NULL, NULL, X509_get0_notAfter(ret));
+
+        if (!ASN1_TIME_diff(&tdays, NULL, NULL, X509_get0_notAfter(ret)))
+            goto end;
         days = tdays;
     }