commit 14db9bbd710ac8aaaee89280e9b5ffb5afedb712
author Rob Percival <robpercival@google.com> Tue Mar 08 19:09:06 2016 +0000
committer Rich Salz <rsalz@openssl.org> Wed Mar 09 11:34:48 2016 -0500
tree fcbb23bd46bfe0cdf80481f2c77af37512c7429b
parent 21b908a8f95a4b2e095c64876c6991020e6c099e

Removes SCT_LIST_set_source and SCT_LIST_set0_logs

Both of these functions can easily be implemented by callers instead.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>

test/ct_test.c

diff --git a/test/ct_test.c b/test/ct_test.c
index 190a98f..2e58419 100644
--- a/test/ct_test.c
+++ b/test/ct_test.c
@@ -340,12 +340,18 @@
 
             if (fixture.test_validity) {
                 int are_scts_validated = 0;
+                int i;
+
                 scts = X509V3_EXT_d2i(sct_extension);
-                if (SCT_LIST_set_source(scts, SCT_SOURCE_X509V3_EXTENSION) !=
-                    sk_SCT_num(scts)) {
-                    fprintf(stderr,
-                            "Error setting SCT source to X509v3 extension\n");
-                    test_failed = 1;
+                for (i = 0; i < sk_SCT_num(scts); ++i) {
+                    SCT *sct_i = sk_SCT_value(scts, i);
+
+                    if (!SCT_set_source(sct_i, SCT_SOURCE_X509V3_EXTENSION)) {
+                        fprintf(stderr,
+                                "Error setting SCT source to X509v3 extension\n");
+                        test_failed = 1;
+                        goto end;
+                    }
                 }
 
                 are_scts_validated = SCT_LIST_validate(scts, ct_policy_ctx);
@@ -355,7 +361,6 @@
                 } else if (!are_scts_validated) {
                     int invalid_sct_count = 0;
                     int valid_sct_count = 0;
-                    int i;
 
                     for (i = 0; i < sk_SCT_num(scts); ++i) {
                         SCT *sct_i = sk_SCT_value(scts, i);