commit 222561fe8ef510f336417a666f69f81ddc9b8fe4
author Rich Salz <rsalz@openssl.org> Thu Apr 30 17:33:59 2015 -0400
committer Rich Salz <rsalz@openssl.org> Thu Apr 30 17:33:59 2015 -0400
tree 70bc6af70550022bc7b7af45bd3c6d64d7fc2680
parent 2ace745022f5af0709297e96eb0b0829c87c4291

free NULL cleanup 5a

Don't check for NULL before calling a free routine.  This gets X509_.*free:
    x509_name_ex_free X509_policy_tree_free X509_VERIFY_PARAM_free
    X509_STORE_free X509_STORE_CTX_free X509_PKEY_free
    X509_OBJECT_free_contents X509_LOOKUP_free X509_INFO_free

Reviewed-by: Richard Levitte <levitte@openssl.org>

crypto/evp/p_lib.c

diff --git a/crypto/evp/p_lib.c b/crypto/evp/p_lib.c
index c9e971e..c163e47 100644
--- a/crypto/evp/p_lib.c
+++ b/crypto/evp/p_lib.c
@@ -401,8 +401,7 @@
     }
 #endif
     EVP_PKEY_free_it(x);
-    if (x->attributes)
-        sk_X509_ATTRIBUTE_pop_free(x->attributes, X509_ATTRIBUTE_free);
+    sk_X509_ATTRIBUTE_pop_free(x->attributes, X509_ATTRIBUTE_free);
     OPENSSL_free(x);
 }