Add asn1_time_to_tm function and check days in month
Based on discussion in PR #3566. Reduce duplicated code in original
asn1_utctime_to_tm and asn1_generalizedtime_to_tm, and introduce a new
internal function asn1_time_to_tm. This function also checks if the days
in the input time string is valid or not for the corresponding month.
Test cases are also added.
Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/3905)
diff --git a/test/x509_time_test.c b/test/x509_time_test.c
index 6812805..21f6980 100644
--- a/test/x509_time_test.c
+++ b/test/x509_time_test.c
@@ -56,6 +56,14 @@
"20170217180105Z", 0, 1, -1, NULL,
},
{
+ /* not leap year, check only */
+ "20170229180105Z", 0, 0, -1, NULL,
+ },
+ {
+ /* leap year, check only */
+ "20160229180105Z", 0, 1, -1, NULL,
+ },
+ {
/* SS is missing, check only */
"201702171801Z", 0, 0, -1, NULL,
},
@@ -97,6 +105,14 @@
"1702171801Z", 0, 0, -1, NULL,
},
{
+ /* not leap year, check only */
+ "050229180101Z", 0, 0, -1, NULL,
+ },
+ {
+ /* leap year, check only */
+ "040229180101Z", 0, 1, -1, NULL,
+ },
+ {
/* time zone, check only */
"170217180154+0800", 0, 0, -1, NULL,
},
