commit 466d30c0d7fa861a5fcbaebd2e2010a8c2aea322
author Nicola Tuveri <nic.tuv@gmail.com> Sat Jun 27 01:42:49 2020 +0300
committer Nicola Tuveri <nic.tuv@gmail.com> Mon Jul 06 19:15:36 2020 +0300
tree 3d120f1c001c78140c74e0bde4a11a2aa7d4340b
parent e0137ca92b4abf65acde15b255ae58d7e76af22f

[apps/genpkey] exit status should not be 0 on output errors

If the key is to be serialized or printed as text and the framework
returns an error, the app should signal the failure to the user using
a non-zero exit status.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/12305)

apps/genpkey.c

diff --git a/apps/genpkey.c b/apps/genpkey.c
index 8954ef1..4a4a83f 100644
--- a/apps/genpkey.c
+++ b/apps/genpkey.c
@@ -189,9 +189,12 @@
         goto end;
     }
 
+    ret = 0;
+
     if (rv <= 0) {
         BIO_puts(bio_err, "Error writing key\n");
         ERR_print_errors(bio_err);
+        ret = 1;
     }
 
     if (text) {
@@ -203,11 +206,10 @@
         if (rv <= 0) {
             BIO_puts(bio_err, "Error printing key\n");
             ERR_print_errors(bio_err);
+            ret = 1;
         }
     }
 
-    ret = 0;
-
  end:
     EVP_PKEY_free(pkey);
     EVP_PKEY_CTX_free(ctx);