commit 5e56f4587de2f2e06c079272fa4d6712d56dbcf0
author Pauli <pauli@openssl.org> Tue Jun 29 08:26:11 2021 +1000
committer Pauli <pauli@openssl.org> Wed Jun 30 13:55:09 2021 +1000
tree 5154d77f4240cc46d7bb920cc3bf9c1d59900c60
parent 98431c431366ec3445e92cf4c50a1d3ac80573a5

evp: fix coverity 1473380 Copy into fixed size buffer (STRING_OVERFLOW)

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15943)

crypto/evp/ctrl_params_translate.c

diff --git a/crypto/evp/ctrl_params_translate.c b/crypto/evp/ctrl_params_translate.c
index 6998dcc..c532e57 100644
--- a/crypto/evp/ctrl_params_translate.c
+++ b/crypto/evp/ctrl_params_translate.c
@@ -1353,7 +1353,9 @@
         if (i == OSSL_NELEM(str_value_map)) {
             BIO_snprintf(ctx->name_buf, sizeof(ctx->name_buf), "%d", ctx->p1);
         } else {
-            strcpy(ctx->name_buf, str_value_map[i].ptr);
+            strncpy(ctx->name_buf, str_value_map[i].ptr, sizeof(ctx->name_buf));
+            /* This won't truncate but it will quiet static analysers */
+            ctx->name_buf[sizeof(ctx->name_buf) - 1] = '\0';
         }
         ctx->p2 = ctx->name_buf;
         ctx->p1 = strlen(ctx->p2);