commit 62adbcee392ba1061bf213174e8c59728e00860e
author Rich Salz <rsalz@openssl.org> Sat Apr 11 10:22:36 2015 -0400
committer Rich Salz <rsalz@openssl.org> Sat Apr 11 10:22:36 2015 -0400
tree b0a97dcc7e5d9ff3a60b638e45b254a234b83a41
parent e2010b202a52be9120582537845f422a60d5d8c0

free NULL cleanup 10

Avoid checking for NULL before calling free functions.  This gets
ssl.*free:
    ssl_sess_cert_free ssl_free ssl_excert_free ssl_cert_free
    SSL_free SSL_SRP_CTX_free SSL_SESSION_free SSL_CTX_free
    SSL_CTX_SRP_CTX_free SSL_CONF_CTX_free

Reviewed-by: Kurt Roeckx <kurt@openssl.org>

ssl/s3_clnt.c

diff --git a/ssl/s3_clnt.c b/ssl/s3_clnt.c
index 6da1258..404f7f9 100644
--- a/ssl/s3_clnt.c
+++ b/ssl/s3_clnt.c
@@ -1215,8 +1215,7 @@
     if (sc == NULL)
         goto err;
 
-    if (s->session->sess_cert)
-        ssl_sess_cert_free(s->session->sess_cert);
+    ssl_sess_cert_free(s->session->sess_cert);
     s->session->sess_cert = sc;
 
     sc->cert_chain = sk;